Skip to content

馃悰 Fix duplicated welcome messages by adding nonce #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Romitou merged 1 commit into from
Aug 8, 2026
Merged

馃悰 Fix duplicated welcome messages by adding nonce #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/listeners/client/guildMemberAdd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,7 @@ import * as messages from '#config/messages';
import { channels } from '#config/settings';

export class GuildMemberAddListener extends Listener {
private deduplication = new Set<string>();

public override async run(member: GuildMember): Promise<void> {
if (this.deduplication.has(member.id)) return;

this.deduplication.add(member.id);
setTimeout(() => this.deduplication.delete(member.id), 60_000);

await this._greet(member);
}

Expand All @@ -24,6 +17,11 @@ export class GuildMemberAddListener extends Listener {
if (!channel || !channel.isTextBased()) return;

const content = pupa(randomMessage, { member });
await channel.send(content);

// Keep welcome sends idempotent.
const joinedTimestamp = member.joinedTimestamp ?? Date.now();
const nonce = `${member.id}:${joinedTimestamp}`;

await channel.send({ content, nonce, enforceNonce: true });
}
}
Loading