Skip to content

Use TCHAR in mp3checker#23

Open
Sjord wants to merge 4 commits into
masterfrom
windows-unicode
Open

Use TCHAR in mp3checker#23
Sjord wants to merge 4 commits into
masterfrom
windows-unicode

Conversation

@Sjord

@Sjord Sjord commented Jun 8, 2017

Copy link
Copy Markdown
Owner

To support unicode characters

To support unicode characters
@Sjord

Sjord commented Jun 8, 2017

Copy link
Copy Markdown
Owner Author

Todo:

  • Combo_AddDrives in rebar.c
  • Commented sprintf in mp3checker.c
  • fileerror in checkfile.c
  • error in checkarguments.c
  • merge declarations in checkarguments.h

Sjord added 3 commits June 8, 2017 16:20
Even though TCHAR is just char ifndef WIN32
sprintf no longer works with TCHAR, and it was commented anyway
@Sjord

Sjord commented Jun 13, 2017

Copy link
Copy Markdown
Owner Author

I am getting convinced that using TCHAR is not the right way to approach this. Instead we should use UTF8 and only convert to UTF16 when calling Windows API functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant