Skip to content

Fix Marketplace language links - #9

Merged
SivanCola merged 1 commit into
mainfrom
codex/fix-marketplace-language-links
Aug 3, 2026
Merged

Fix Marketplace language links#9
SivanCola merged 1 commit into
mainfrom
codex/fix-marketplace-language-links

Conversation

@SivanCola

@SivanCola SivanCola commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the relative Simplified Chinese README link with an absolute GitHub URL
  • update the reciprocal English link for consistent behavior outside the repository view

Root cause

Visual Studio Marketplace resolves the relative ./README.zh-CN.md link against marketplace.visualstudio.com, producing a nonexistent /README.zh-CN.md URL and a 404.

Impact

After the next VSIX is published to Visual Studio Marketplace, the language switch links will work from both GitHub and the Marketplace-rendered README. Extension runtime behavior is unchanged.

Merging this PR alone does not refresh the currently published Marketplace README. Issue #2 should remain open until a release containing this change is published and the live listing is verified.

Validation

  • git diff --check
  • npm run lint
  • npm test (48 passed)
  • npm run package:vsix
  • npm run verify:vsix-contents
  • confirmed both absolute README URLs return HTTP 200
  • confirmed the packaged English and Chinese READMEs contain the absolute links
  • scanned both README files for remaining relative language links

CI note

GitHub CI currently stops at npm audit --audit-level=high before running its code checks. The audit reports four high-severity transitive vulnerabilities (brace-expansion, fast-uri, js-yaml, and linkify-it) under @vscode/vsce. This PR does not modify package.json or package-lock.json; dependency remediation should be handled separately.

Refs #2

@SivanCola
SivanCola marked this pull request as ready for review August 3, 2026 15:30
@SivanCola
SivanCola merged commit c57a733 into main Aug 3, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant