Fix Windows ACP process launch - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
where reasonixresults without selecting extensionless npm shell shims.cmd/.batwrappersRoot cause
v0.3.0 spawned the PATH/configured npm shim directly with the Node child process API. Windows cannot directly execute
.cmd/.batwrappers without command interpretation, producingEINVAL; selecting the extensionless npm shell shim producedENOENT.Validation
npm run lintnpm test(65 tests)npm run test:vscodenpm run smoke:acpnpm audit --audit-level=highnpm run package:vsixnpm run verify:vsix-contentsreasonix.cmdand PATH modes passed; the real Reasonix 1.19.4 shim resolved to the packaged ARM64 executable and executed; ACPinitializepassed (the clean VM still needs a configured model forsession/new)Closes #3