Skip to content

Fix Webview theme adaptation - #11

Merged
SivanCola merged 1 commit into
mainfrom
codex/fix-webview-theme-adaptation
Aug 3, 2026
Merged

Fix Webview theme adaptation#11
SivanCola merged 1 commit into
mainfrom
codex/fix-webview-theme-adaptation

Conversation

@SivanCola

@SivanCola SivanCola commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • derive Webview backgrounds, panels, borders, shadows, and subtle highlights from VS Code theme colors
  • remove dark-only surface colors that made the chat view look gray and disconnected in light themes
  • preserve Reasonix accents while deriving readable foreground variants from the active VS Code foreground
  • add regression coverage for old dark-only colors and WCAG contrast across representative light, dark, and mid-tone themes

Root cause

The Webview already consumed some --vscode-* colors, but its shared Reasonix surface palette mixed fixed near-black colors and white highlights into those values. In light themes this darkened the entire chat surface and left several controls with dark-theme-specific foregrounds.

Validation

  • npm run lint
  • npm test (69 tests)
  • npm audit --audit-level=high
  • npm run smoke:acp
  • npm run package:vsix
  • npm run verify:vsix-contents
  • interactive light/dark Webview preview with no console warnings or errors

The local macOS npm run test:vscode runner now resolves the VS Code executable after the base dependency update, but the local process is terminated by SIGKILL before test assertions start. Linux and Windows Extension Host paths remain covered by CI.

Closes #6

@SivanCola
SivanCola force-pushed the codex/fix-webview-theme-adaptation branch 2 times, most recently from 03195a8 to 7dd6c62 Compare August 3, 2026 15:55
@SivanCola
SivanCola marked this pull request as ready for review August 3, 2026 16:03
@SivanCola
SivanCola force-pushed the codex/fix-webview-theme-adaptation branch from 7dd6c62 to 5ab3901 Compare August 3, 2026 16:06
@SivanCola
SivanCola merged commit 94ffb8c into main Aug 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

样式过于丑陋了

1 participant