Skip to content

add assignment_1#1

Open
SimonChoi2591 wants to merge 3 commits into
mainfrom
assignment-1
Open

add assignment_1#1
SimonChoi2591 wants to merge 3 commits into
mainfrom
assignment-1

Conversation

@SimonChoi2591

Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

adding KNN code for assignment-1

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@PatelVishakh PatelVishakh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 1:Complete. Great work! Suggested Changes:


Q1)III) The type of variable is categorical. In a data science setting, this question is asking whether the variable is numerical or categorial (Integer, continuous, ordinal are for distinguishing further) to assess whether classification or regression methods should be used. The complete statement should Class is a Categorical Variable, represented here in integers (0,1,2) stored in our Dataframe as int64.

Q3) No need for the first code cell

Q3)II)range(1:51) as python doesn’t include last index/ no need to do skip since our grid is not very big.

Vishakh Patel [LS]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants