-
Notifications
You must be signed in to change notification settings - Fork 54
Issue 512 3D-1D coupling #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taeoukkim
wants to merge
55
commits into
SimVascular:main
Choose a base branch
from
taeoukkim:issue-512-pr-from-fa058d0-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
26dbb1e
Add 3D-1D coupling via svOneDSolver shared library interface
taeoukkim 9512433
Fix code review issues: remove unused variable, safer char* buffer, c…
taeoukkim a5f1b56
Redesign 1D coupling for parallel per-model execution across MPI ranks
taeoukkim 2afd223
Address code review: init sv1DTime from com_mod.time, rename nModels→…
taeoukkim 68561d0
Fix calc_sv1D: split solve and broadcast into two phases for true MPI…
taeoukkim abe0fa6
Support mixed sv1D + RCR boundary conditions
taeoukkim 4e778d5
Update error message to reflect RCR+sv1D is now allowed
taeoukkim 21daef5
init_sv1D: separate init loop from metadata broadcast for true parall…
taeoukkim 05044bd
sv1D: add nProcs >= nTotalModels guard in init_sv1D
taeoukkim d088f23
rename sv1D → svOneD: files, namespace, functions, class, variables
taeoukkim 1127a71
Add example solver.xml with 2 svOneD-coupled faces
taeoukkim d88edb1
Migrate svOneD 1D coupling to CoupledBoundaryCondition interface
taeoukkim f3d398f
Fix missing Qo_ in copy/move constructors and assignment operators
taeoukkim 73f5d91
Fix library name typo in svOneD_subroutines.cpp comment
taeoukkim 07883f6
fix DIR coupling bug: set_bc.cpp uses get_Qn() for DIR, svOneD calls …
taeoukkim e7b5135
fix DIR Coupled BCs: route to set_bc_dir_l (velocity), exclude from s…
taeoukkim 852b821
fix Bug 5: compute_pressures() for any DIR Coupled BC (not just svOne…
taeoukkim 5119968
fix Bug 6: auto-enforce bType_flx for DIR Coupled BCs so Q/area gives…
taeoukkim 2f49742
feat: enable svZeroD (0D) + RCR coexistence, mirroring svOneD behavior
taeoukkim 0c012dc
fix: allow RCR BC to coexist with svZeroD coupling, fix scheme overwrite
taeoukkim c74ceeb
fix: distribute cplBC.xo to slave processes when svZeroD+RCR coexist
taeoukkim 24adc2e
fix: broadcast useSv1D to slaves and add RCR integration in sv1D txt.…
taeoukkim 7c4f484
fix: broadcast sv1d_solver_interface data to all MPI ranks in distrib…
taeoukkim 283f668
fix: update run_1d_simulation_step_1d to pass last_flag and save_incr
taeoukkim 81c9a31
fix: recompute NEU coupling Qn_ from converged Yn before 1D L-step co…
taeoukkim 543d0a4
fix: negate 1D solver flow for DIR coupling to match svZeroD sign con…
taeoukkim a0ed4ca
fix: set bType_zp for Coupled-DIR BCs to preserve flow rate
taeoukkim 8327f4c
fix: register Coupled-DIR face as BC_TYPE_Dir in fsi_ls_ini to exclud…
taeoukkim ac5eb22
feat: add pressure ramp for 1D coupling initialization (Method 2)
taeoukkim 9ee8189
Add under-relaxation for DIR coupling pressure passed to 1D solver
taeoukkim d9657a4
Apply under-relaxation to Q output for 1D Dirichlet coupling
taeoukkim 5566f85
feat: add under-relaxation to NEU coupling pressure output
taeoukkim 097bbd3
remove -dir at relax_factor
taeoukkim c727c57
error at the previous commit. this is correct version after remove -d…
taeoukkim 4f8601a
Rebase onto collaborator cleanup (6a2a54b): svZeroD_subroutines→svZer…
taeoukkim c1861a8
Fix const-correctness in CappingSurface: face() const, mutable valM_,…
taeoukkim cd0d072
fix: broadcast DIR flowrate Qo/Qn to all MPI ranks in svZeroD coupling
taeoukkim a6e0c22
feat: add ramp/relax support to 3D-0D coupling (svZeroD)
taeoukkim df85a87
feat: add ramp/relax to NEU input (Q sent to 0D solver)
taeoukkim afbbd46
fix bug
taeoukkim b74fc99
fix neumann coupling under relaxation and ramping
taeoukkim f01218a
change Neu to Robin to avoid back flow
taeoukkim ff76805
fix: remove robin part, keep only stabilization term. enough to converge
taeoukkim 42e3039
enhancement: available to use both 3D-1D coupling and 3D-0D coupling …
taeoukkim ab9872a
fix: remove stale TTPInitialConditionsParameters reference
taeoukkim 3ed2c50
fix: remove stale TTP initial condition parameter code
taeoukkim 9b8675d
fix: restore coupled_bc_type initialization after mixed 0D/1D merge
taeoukkim 3cc5637
fix: remove stale static CmMod definition
taeoukkim 4b968c1
remove coupling fom the parameter naming
taeoukkim 91033e6
Merge branch 'main' into issue-512-pr-from-fa058d0-clean
aabrown100-git e1fc5f1
Merge branch 'main' into issue-512-pr-from-fa058d0-clean
ktbolt 001d626
Merge branch 'main' into issue-512-pr-from-fa058d0-clean
ktbolt 99e2944
save review changes before clean up
taeoukkim a5c9206
Merge branch 'main' into issue-512-pr-from-fa058d0-clean
ktbolt b97873d
second review change
taeoukkim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept these members for now because they are used as intermediate storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this: the AI comment says that these members are written to but never read from. Do you mean to say that they are indeed read from, and that AI missed it? Or that you plan on reading from them in further developments of this work?