ci: gate releases on CI passing before tagging#2
Merged
Conversation
publish.yml triggers directly on push: tags: ["v*"], with no way to depend on ci.yml passing since GitHub Actions can't needs: a job defined in a separate workflow file. Add scripts/check-release-ready.sh to check the most recent ci.yml run for a commit before it gets tagged, and RELEASING.md documenting the release procedure with that check as an explicit step. Closes #1
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
openyxdb-docs | 5a4b9e5 | Jul 18 2026, 10:45 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish.ymltriggers directly onpush: tags: ["v*"], with no dependency onci.ymlpassing - a tag push can kick off a PyPI publish even if CI never ran for that commit, or is red. GitHub Actions has no way for one workflow file toneeds:a job defined in a separate workflow file, so this has to be enforced before the tag is created, not insidepublish.ymlitself.scripts/check-release-ready.sh, which resolves a ref (defaultHEAD) to a commit and checks the most recentci.ymlrun for that commit viagh run list -w ci.yml -c <sha> --json status,conclusion,url -L 1. Fails with a clear message (including the run URL when available) unless the run iscompletedwithconclusion: success.RELEASING.mddocumenting the release procedure (bump version, update changelog, commit, runcheck-release-ready.sh, tag, push, verify), with the CI check as an explicit step.This repo has no
audit.yml, so onlyci.ymlis checked (matches the fix already going into sibling OpenMassSpec-ecosystem repos with the same gap).Closes #1
Test plan
./scripts/check-release-ready.sh mainagainst currentmainHEAD (release: v1.4.3, commit 13b0206) - correctly found the passingci.ymlrun and exited 0.v1.4.1) to confirm^{commit}peeling resolves annotated tag objects to the underlying commit rather than the tag SHA.v1.0.2, noci.ymlrun for that commit) to confirm it fails with a clear message and exit 1.