Enhancements#1
Merged
Merged
Conversation
- Updated the license identifier from AGPL-3.0-or-later to AGPL-3.0-only across multiple files. - Expanded the `Eccentricity` struct to include methods for creating elliptic and hyperbolic eccentricities with error handling. - Introduced `ConicRegime` enum to classify conic sections based on eccentricity. - Added `EccentricityError` enum for detailed error reporting during eccentricity construction. - Modified `KeplerianElements` to validate semi-major axis against eccentricity regime. - Enhanced `try_to_cartesian` method to return errors for invalid gravitational parameters and semi-latus rectum. - Introduced fallible versions of transfer helper functions, including `try_orbital_period`, `try_hohmann_delta_v`, `try_vis_viva_speed`, and `try_escape_speed`, with appropriate error handling. - Added a new `prelude` module for convenient re-exports of commonly used items. - Updated tests to reflect changes in anomaly handling and ensure coverage of new error paths.
…er calculations - Implement tests for converting various error types to KeplerError in `error.rs`. - Add tests for validating the propagation of hyperbolic states and handling parabolic states in `problem.rs`. - Introduce tests for Lambert n-rev calculations in `lambert/typed.rs`. - Enhance search functionality tests in `search.rs` to cover success and failure scenarios. - Validate state cloning and velocity accessors in `state.rs`. - Expand transfer function tests in `transfer.rs` to include orbital period and delta-v calculations. - Remove outdated coverage tests from `coverage_extras.rs`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.