Add stats table#194
Open
chris124567 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an incrementally maintained stats table in the SQLite persistence layer to make UploadStats queries scale better on larger databases (per Issue #182), replacing the prior full-table aggregation approach.
Changes:
- Added a
statstable plus helpers to increment/decrement upload-pipeline counters transactionally. - Updated object + multipart upload write paths to maintain stats (pending/uploaded/orphaned/multipart counts and sizes) as state changes occur.
- Added schema init + migration backfill logic, and expanded
TestUploadStatsto cover additional state transitions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
sia/persist/sqlite/stats.go |
Introduces stat keys, incremental update helpers, and the new Store.UploadStats() implementation backed by the stats table. |
sia/persist/sqlite/objects.go |
Updates object lifecycle operations to adjust stats and moves UploadStats out of this file. |
sia/persist/sqlite/objects_test.go |
Extends TestUploadStats to validate stat counter behavior across more transitions. |
sia/persist/sqlite/multipart.go |
Updates multipart create/complete/abort flows to maintain multipart_uploads and pending-object stats. |
sia/persist/sqlite/migrations.go |
Adds migration to create/backfill the stats table for existing DBs. |
sia/persist/sqlite/init.sql |
Adds stats table creation and initialization for fresh DBs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
peterjan
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #182