Preserve heredoc body when translating multi-line T.let assertions

[styrmis]

When T.let(...) spans multiple lines and wraps a heredoc, the replacement range covers the entire call including the heredoc body. Since the value node's source range only covers the opener line (e.g. <<~MSG.strip), the body and terminator were silently dropped, producing syntactically broken Ruby.

[KaanOzkan]

You can use

spoom/lib/spoom/sorbet/translate/translator.rb

Line 55 in a2a5712

def adjust_to_line_end(offset)

[KaanOzkan]

If we have something like

both = T.let(
  foo(<<~A, <<~B),
    first
  A
    second
  B
  String,
)

stopping at the first heredoc would end up dropping subsequent ones. I think we can support this case too.

Something like

#: (Prism::Node) -> Array[Integer]
def heredoc_end_offsets(node)
  offsets = [] #: Array[Integer]

  case node
  when Prism::StringNode, Prism::InterpolatedStringNode
    opening = node.opening_loc
    closing = node.closing_loc

    if opening && closing && opening.start_line != closing.start_line
      offsets << closing.end_offset
    end
  end

  node.each_child_node do |child|
    offsets.concat(heredoc_end_offsets(child))
  end

  offsets
end

Using each_child_node should take care of it for us. And then inside heredoc_body_within_range we can do

heredoc_end = heredoc_end_offsets(node)
  .select { |offset| offset <= replace_end_offset }
  .max
return unless heredoc_end