Accept multiple queries in search and fuzzy search#904
Open
vinistock wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in some use cases, we want to search the graph for more than one query. Invoking
graph.searchmultiple times means traversing all declarations and spawning threads for each invocation.This PR starts accepting multiple queries instead, which allows us to search the entire graph in one go.
I also noticed that our empty query matching (which returns all declarations) was happening inside of the parallel loop, but that's unnecessary work. Empty matches everything, so we just need to return early before we even spawn any threads.