Add singleton(X)[Y] type support#570
Merged
Merged
Conversation
Translates RBS singleton(X)[Y] to T.class_of(X)[Y] and vice versa. RBS 4.0.1 added type argument support to ClassSingleton (ruby/rbs#2502), enabling parity with Sorbet's T.class_of(X)[Y] syntax.
Morriar
force-pushed
the
singleton-type-args
branch
from
5b2e47e to
513e7b8
Compare
vinistock
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements bidirectional support for
singleton(X)[Y]↔T.class_of(X)[Y].Now that RBS 4.0.1 ships
singleton(X)[Y]syntax (ruby/rbs#2502), we can properly round-trip this type instead of dropping the type parameter.Changes
>= 4.0.1TypeTranslator: translatesingleton(X)[Y]→T.class_of(X)[Y]RBSPrinter: printT.class_of(X)[Y]→singleton(X)[Y]Step towards https://github.com/Shopify/team-ruby-dx/issues/1460
Supersedes #558