Fix observed generation - #29
Draft
Yanisdje wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix observedGeneration not being set when a FlinkDeployment is created with spec.job.state: suspended. The operator returned early without updating any status fields, leaving observedGeneration null and causing deployment tools like kapp to hang indefinitely.
Additionally, add observedGeneration to FlinkBlueGreenDeploymentStatus which was missing entirely.
JIRA issue: https://issues.apache.org/jira/browse/FLINK-39243
Discussion: https://lists.apache.org/thread/4pk4v0wx901t4blsncx4j1jm8csc59z2
Brief change log
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
Added testSuspendedFirstDeploymentSetsObservedGeneration in ApplicationReconcilerTest verifying observedGeneration is set, no resources are created, and resume to RUNNING works