Skip to content

Fix NPE in FlinkStateSnapshot cleanup causing orphaned CRs and blocked namespace deletion #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yanisdje merged 4 commits into from
Mar 31, 2026
Merged

Fix NPE in FlinkStateSnapshot cleanup causing orphaned CRs and blocked namespace deletion #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21867b8
orphaned state snapshot fix
Yanisdje Mar 30, 2026
c7bd562
add tests
Yanisdje Mar 30, 2026
49a9610
change approach
Yanisdje Mar 30, 2026
7f7e2a6
Remove updateErrorStatus check
Yanisdje Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...in/java/org/apache/flink/kubernetes/operator/controller/FlinkStateSnapshotController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ public UpdateControl<FlinkStateSnapshot> reconcile(
@Override
public DeleteControl cleanup(
FlinkStateSnapshot flinkStateSnapshot, Context<FlinkStateSnapshot> josdkContext) {
if (flinkStateSnapshot.getStatus() == null) {
LOG.info(
"Snapshot {} has no status, was never reconciled. Removing finalizer.",
flinkStateSnapshot.getMetadata().getName());
return DeleteControl.defaultDelete();
}
var ctx = ctxFactory.getFlinkStateSnapshotContext(flinkStateSnapshot, josdkContext);
try {
metricManager.onRemove(flinkStateSnapshot);
Expand Down
14 changes: 14 additions & 0 deletions ...ava/org/apache/flink/kubernetes/operator/controller/FlinkStateSnapshotControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,20 @@ public void testMetrics() {
assertSnapshotMetrics(listener, TestUtils.TEST_NAMESPACE, Map.of(), Map.of());
}

@Test
public void testCleanupWithNullStatus() {
var deployment = createDeployment();
context = TestUtils.createSnapshotContext(client, deployment);

var savepoint = createSavepoint(deployment);
savepoint.setStatus(null);
assertDeleteControl(controller.cleanup(savepoint, context), true, null);

var checkpoint = createCheckpoint(deployment, CheckpointType.FULL, 0);
checkpoint.setStatus(null);
assertDeleteControl(controller.cleanup(checkpoint, context), true, null);
}

private FlinkStateSnapshot createSavepoint(FlinkDeployment deployment) {
return createSavepoint(deployment, false, 7);
}
Expand Down
Loading