[Tests] Remove filesystem mocks in bundle-ui-step.test.ts#7571
[Tests] Remove filesystem mocks in bundle-ui-step.test.ts#7571gonzaloriestra wants to merge 1 commit into
Conversation
Refactor executeBundleUIStep tests to use real temporary directories instead of global filesystem mocks. This ensures tests verify actual file operations and handle path resolution nuances correctly.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Filesystem mocks in tests prevent verifying actual filesystem side effects and can lead to implementation-coupled tests that don't catch real-world path handling issues.
WHAT is this pull request doing?
Refactors `packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts` to replace global `vi.mock('@shopify/cli-kit/node/fs')` with real filesystem operations using `inTemporaryDirectory`. It uses `mkdir` and `writeFile` to set up the test environment and `fileExists` to verify the success of `copyFile`.
How to test your changes?
CI
Post-release steps
N/A
Checklist
PR created automatically by Jules for task 18014390488825622297 started by @gonzaloriestra