Skip to content

[Tests] Remove filesystem mocks in bundle-ui-step.test.ts#7571

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297
Draft

[Tests] Remove filesystem mocks in bundle-ui-step.test.ts#7571
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Filesystem mocks in tests prevent verifying actual filesystem side effects and can lead to implementation-coupled tests that don't catch real-world path handling issues.

WHAT is this pull request doing?

Refactors `packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts` to replace global `vi.mock('@shopify/cli-kit/node/fs')` with real filesystem operations using `inTemporaryDirectory`. It uses `mkdir` and `writeFile` to set up the test environment and `fileExists` to verify the success of `copyFile`.

How to test your changes?

CI

Post-release steps

N/A

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (`patch` for bug fixes · `minor` for new features · `major` for breaking changes) and added a changeset with `pnpm changeset add`

PR created automatically by Jules for task 18014390488825622297 started by @gonzaloriestra

Refactor executeBundleUIStep tests to use real temporary directories
instead of global filesystem mocks. This ensures tests verify actual
file operations and handle path resolution nuances correctly.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant