[Refactor] Simplify normalizeDelimitedString#7565
Conversation
Refactor normalizeDelimitedString to use a declarative pipeline and the uniq helper. This improves readability and consistency with other collection-handling code in the repository.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The current implementation of
normalizeDelimitedStringis imperative and uses several intermediate variables. It also manually implements deduplication instead of using the existinguniqutility helper.WHAT is this pull request doing?
Refactors
normalizeDelimitedStringinpackages/cli-kit/src/public/common/string.tsto use a declarative chaining approach and theuniqutility fromcommon/array.ts.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 14687650256661895799 started by @gonzaloriestra