Skip to content

fix: 팀명 수정 시 앞뒤 공백 제거 누락 수정 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LeeJeongHeon02 wants to merge 2 commits into from
Closed

fix: 팀명 수정 시 앞뒤 공백 제거 누락 수정 #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dff3b8
fix: 팀명 수정 시 앞뒤 공백 제거 누락 수정
LeeJeongHeon02 Jul 21, 2026
0e67e14
test: 팀명 trim 테스트가 실제 DB 반영을 검증하도록 보강 (코드리뷰 반영)
LeeJeongHeon02 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/shinhan/klljs/domain/team/service/TeamMemberManagementService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import com.shinhan.klljs.domain.team.repository.TeamRepository;
import com.shinhan.klljs.global.apiPayload.code.GeneralErrorCode;
import com.shinhan.klljs.global.apiPayload.exception.GeneralException;
import com.shinhan.klljs.global.util.Texts;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
Expand Down Expand Up @@ -72,7 +73,7 @@ public TeamRenameResponse renameTeam(Long requesterId, Long teamId, String teamN
throw new GeneralException(TeamErrorCode.TEAM_SETTINGS_FORBIDDEN);
}

team.rename(teamName);
team.rename(Texts.trim(teamName));
return TeamRenameResponse.of(team);
}

Expand Down
15 changes: 15 additions & 0 deletions src/test/java/com/shinhan/klljs/domain/team/service/TeamMemberManagementServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,21 @@ void renameTeam_allowsOwnerAndAdminButRejectsMember() {
assertThat(team.getTeamName()).isEqualTo("관리자가 바꾼 팀명");
}

@Test
void renameTeam_trimsEdgeWhitespace() {
Team team = persistTeam(TeamStatus.ACTIVE);
TeamMember owner = persistMember(team, "오너", "owner@example.com", TeamMemberRole.OWNER, TeamMemberStatus.ACTIVE);
entityManager.flush();

TeamRenameResponse response = service.renameTeam(owner.getUser().getId(), team.getId(), " 공백 팀명 ");
entityManager.flush();
entityManager.clear();

assertThat(response.teamName()).isEqualTo("공백 팀명");
// 영속성 컨텍스트를 비우고 다시 조회해서, 메모리상 엔티티 상태가 아니라 실제 DB 반영 여부를 확인한다.
assertThat(entityManager.find(Team.class, team.getId()).getTeamName()).isEqualTo("공백 팀명");
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

@Test
void removeAndLeave_changeMembershipStatuses() {
Team team = persistTeam(TeamStatus.ACTIVE);
Expand Down
Loading