feat(desktop): add Upstage provider + workspace/session fixes - #37
Open
hunkim wants to merge 3 commits into
Open
feat(desktop): add Upstage provider + workspace/session fixes#37hunkim wants to merge 3 commits into
hunkim wants to merge 3 commits into
Conversation
Companion to the CLI change: same provider in op-core config/ credentials/settings/builder, sidebar credential status, model picker (solar-pro3/pro2/mini), and frontend model-name inference. cargo test not run locally (no rust toolchain on this machine); frontend vitest 201/201 passing.
Upstage's chat endpoint rejects function.strict=true, so tool defs for the upstage provider are now built without the strict flag (same treatment as the CLI fix). cargo test not run locally (no rust toolchain); logic mirrors the Python side verified live.
GUI apps launch with cwd=/, so the workspace resolved to the read-only filesystem root and open_session failed silently — the frontend then called solve with a null sessionId. - state: default workspace is ~/OpenPlanter (OPENPLANTER_WORKSPACE env var overrides) - InputBar: if session creation fails, show the error in chat and abort instead of submitting with a null session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop-side follow-up to #36: brings the same Upstage provider to the Tauri app.
upstage_api_key/upstage_base_urlin config, credentials, and settings; provider inference forsolar*model names; default modelsolar-pro3solar-open2Two fixes are included because the app doesn't actually work with Upstage (or at all, when launched from Finder) without them:
strict— Upstage's chat endpoint rejectsfunction.strict: truewith HTTP 400, so tool defs for the upstage provider are built without the flag (same treatment as the CLI in feat: add Upstage provider to CLI agent #36)./, so the workspace resolved to the read-only filesystem root, session creation failed silently, and the frontend then calledsolvewith a null sessionId. The default workspace is now~/OpenPlanter(overridable viaOPENPLANTER_WORKSPACE), and session-creation failures are shown in the chat instead of proceeding with a null session.cargo test -p op-core -p op-tauri→ 287 passed. Frontendvitest→ 201 passed,tscclean. Built and ran the .app locally with a real investigation session.