Clarify inactivity-timeout semantics (0 = off; disabled-resume turns Logging off) - #66
Merged
Merged
Conversation
The Inactive Timeout field's '0 = off' behaviour was only mentioned mid-description; it is now in the label itself ('minutes, 0 = off'). Both inactivity fields now also spell out the consequence that cost a real recording (DEV-793, 2026-07-19): with Resume Rec On Activity disabled, hitting the timeout stops recording permanently and turns Logging OFF in the device's stored config - the device will not record again until reconfigured (firmware taskStationaryDetectionTimer writes recordEn=0 to EEPROM). Text-only change; suite 241 green. v0.1.9.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates Verisense operational-config field schema strings to make inactivity-timeout behavior explicit (notably that 0 disables stationary detection and that disabling “Resume Rec On Activity” can permanently stop recording by turning Logging off in stored config). It also bumps the SDK version to 0.1.9 to ship the updated schema text.
Changes:
- Clarified Inactive Timeout label and description, explicitly documenting
0 = offand the “Logging OFF in stored config” outcome when resume-on-activity is disabled. - Expanded Resume Rec On Activity description to contrast Enabled vs Disabled behavior more explicitly.
- Bumped package version from
0.1.8→0.1.9(including lockfile).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/devices/verisense/operationalConfig.ts |
Updates schema labels/descriptions to clearly document inactivity-timeout and resume-on-activity semantics. |
package.json |
Bumps SDK version to 0.1.9. |
package-lock.json |
Aligns lockfile version metadata with 0.1.9. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from DEV-793's stopped midday recording (2026-07-19): a 45-min Inactive Timeout with Resume-on-Activity disabled silently ended the recording AND turned Logging off in the device's stored config — none of which was obvious from the field text.
Changes (text-only, op-config field schema)
taskStationaryDetectionTimerwritesrecordEn=0to EEPROM — the device won't record again until reconfigured).Suite 241 green. SDK v0.1.9. Companion console PR re-vendors the build (console renders these schema strings verbatim; no console code change).
🤖 Generated with Claude Code