Skip to content

Clarify inactivity-timeout semantics (0 = off; disabled-resume turns Logging off) - #66

Merged
marknolan merged 1 commit into
mainfrom
inactive-timeout-ui-clarity
Jul 19, 2026
Merged

Clarify inactivity-timeout semantics (0 = off; disabled-resume turns Logging off)#66
marknolan merged 1 commit into
mainfrom
inactive-timeout-ui-clarity

Conversation

@marknolan

Copy link
Copy Markdown
Member

Follow-up from DEV-793's stopped midday recording (2026-07-19): a 45-min Inactive Timeout with Resume-on-Activity disabled silently ended the recording AND turned Logging off in the device's stored config — none of which was obvious from the field text.

Changes (text-only, op-config field schema)

  • Inactive Timeout label now reads "(minutes, 0 = off)" — the off semantics are visible at the point of entry, not buried mid-description.
  • Both inactivity descriptions now spell out the destructive path: with Resume Rec On Activity disabled, hitting the timeout stops recording permanently and turns Logging OFF in the stored config (firmware taskStationaryDetectionTimer writes recordEn=0 to EEPROM — the device won't record again until reconfigured).
  • Resume Rec On Activity description now contrasts the Enabled (pause/auto-resume) and Disabled behaviours explicitly.

Suite 241 green. SDK v0.1.9. Companion console PR re-vendors the build (console renders these schema strings verbatim; no console code change).

🤖 Generated with Claude Code

The Inactive Timeout field's '0 = off' behaviour was only mentioned mid-description; it is now in the label itself ('minutes, 0 = off'). Both inactivity fields now also spell out the consequence that cost a real recording (DEV-793, 2026-07-19): with Resume Rec On Activity disabled, hitting the timeout stops recording permanently and turns Logging OFF in the device's stored config - the device will not record again until reconfigured (firmware taskStationaryDetectionTimer writes recordEn=0 to EEPROM). Text-only change; suite 241 green. v0.1.9.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Verisense operational-config field schema strings to make inactivity-timeout behavior explicit (notably that 0 disables stationary detection and that disabling “Resume Rec On Activity” can permanently stop recording by turning Logging off in stored config). It also bumps the SDK version to 0.1.9 to ship the updated schema text.

Changes:

  • Clarified Inactive Timeout label and description, explicitly documenting 0 = off and the “Logging OFF in stored config” outcome when resume-on-activity is disabled.
  • Expanded Resume Rec On Activity description to contrast Enabled vs Disabled behavior more explicitly.
  • Bumped package version from 0.1.80.1.9 (including lockfile).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/devices/verisense/operationalConfig.ts Updates schema labels/descriptions to clearly document inactivity-timeout and resume-on-activity semantics.
package.json Bumps SDK version to 0.1.9.
package-lock.json Aligns lockfile version metadata with 0.1.9.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marknolan
marknolan merged commit 5c4bbab into main Jul 19, 2026
3 checks passed
@marknolan
marknolan deleted the inactive-timeout-ui-clarity branch July 19, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants