Bump BouncyCastle 1.7.0 -> 1.8.9 in GrpcTest (complete replacement for #139) - #202
Open
marknolan wants to merge 1 commit into
Open
Bump BouncyCastle 1.7.0 -> 1.8.9 in GrpcTest (complete replacement for #139)#202marknolan wants to merge 1 commit into
marknolan wants to merge 1 commit into
Conversation
…#139) Dependabot's #139 only updated packages.config, but this project vendors its NuGet packages in git and hard-codes the versioned HintPath, so that change alone would break the build. This commit does the full swap: - packages.config: BouncyCastle 1.7.0 -> 1.8.9 - GrpcTest.csproj HintPath -> packages\BouncyCastle.1.8.9\lib\ (1.8.9 ships lib\BouncyCastle.Crypto.dll; no Net40-Client subfolder) - vendored packages/: BouncyCastle.1.7.0 removed, 1.8.9 added (nupkg from api.nuget.org, force-added to match existing convention) Verified: NuGet restore satisfied from the vendored folder and the project compiles against 1.8.9 (smoke-built retargeted to v4.8 as this machine lacks the net45 targeting pack). Committed bin/ and obj/ build outputs left untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes dependabot's #139, which only updates
packages.config. This project vendors its NuGet packages in git and the csproj hard-codes the versioned HintPath, so #139 alone would break the build. This PR does the full swap:packages.config: BouncyCastle 1.7.0 -> 1.8.9GrpcTest.csprojHintPath ->..\packages\BouncyCastle.1.8.9\lib\BouncyCastle.Crypto.dll(the 1.8.9 package has noNet40-Clientsubfolder)GrpcTest/packages/:BouncyCastle.1.7.0removed,BouncyCastle.1.8.9added (nupkg fetched from api.nuget.org; force-added sincepackages/is now gitignored, matching the existing vendored convention)Verification: NuGet restore is satisfied entirely from the vendored folder, and the project compiles cleanly against 1.8.9 (smoke-built with MSBuild retargeted to v4.8, as the build machine lacks the net45 targeting pack; no source changes were needed).
Notes:
bin/andobj/build outputs were deliberately left untouched — the stalebin/Debug/BouncyCastle.Crypto.dll(1.7.0) will refresh on the next local build. Removingbin/objfrom git entirely would be a good separate cleanup.🤖 Generated with Claude Code