Draft
Add test coverage for custom expiry_delta in create_proposed_transactions#2
Conversation
Add Builder::expiry_height() accessor and Builder::with_expiry_delta() method (gated behind non-standard-fees feature) to allow customizing transaction expiry windows for wallet recovery scenarios. Co-Authored-By: Claude <noreply@anthropic.com>
…iry_delta Add a new function that allows specifying a custom expiry delta when executing transaction proposals. This is useful for wallet recovery scenarios where a shorter expiry window is desired for replacement transactions. Co-Authored-By: Claude <noreply@anthropic.com>
Copilot created this pull request from a session on behalf of
aphelionz
May 28, 2026 14:54
View session
…ta parameter Removed create_proposed_transactions_with_expiry_delta and added an optional expiry_delta: Option<u32> parameter (gated by non-standard-fees feature) to create_proposed_transactions. This simplifies the API while maintaining the same functionality.
Copilot
AI
changed the title
feat: Add configurable transaction expiry delta
Consolidate create_proposed_transactions API with optional expiry_delta parameter
May 28, 2026
- Add create_proposed_transactions_with_expiry_delta helper in testing.rs - Add send_single_step_proposed_transfer_with_custom_expiry test in pool.rs - Enable non-standard-fees feature in zcash_client_sqlite dev-dependencies - Test verifies custom expiry delta (20 blocks) produces correct expiry height
Address code review feedback: use the constant instead of hardcoded 40
Copilot
AI
changed the title
Consolidate create_proposed_transactions API with optional expiry_delta parameter
Add test coverage for custom expiry_delta in create_proposed_transactions
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
expiry_deltaparameter increate_proposed_transactionswas only tested withNone. This adds integration test coverage for custom expiry values.Changes
zcash_client_backend/src/data_api/testing.rs): Addcreate_proposed_transactions_with_expiry_deltamethod gated behindnon-standard-feesfeaturezcash_client_backend/src/data_api/testing/pool.rs): Addsend_single_step_proposed_transfer_with_custom_expirythat verifies custom expiry delta (20 blocks) produces correct expiry heightzcash_client_sqlitenon-standard-feesforzcash_client_backendin sqlite dev-dependenciesExample