fix(plugin): restore plugin load under OpenCode 1.18.4#9
Merged
Conversation
OpenCode 1.18.4's plugin loader iterates Object.values(entryModule) and
throws "Plugin export is not a function" for any export that is not a
function or { server } object. The exported VISION_PLUGIN_TOOL_NAMES
object tripped this, so the plugin failed to load.
Move the constants to a data-only sibling module (tool-names.ts),
import into index.ts without re-export, and repoint the parity test.
index.ts now exports functions only. typecheck clean; 19/19 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCode 1.18.4's loader iterates
Object.values(entryModule)and throws "Plugin export is not a function" for any non-function export. The exportedVISION_PLUGIN_TOOL_NAMESobject broke plugin load.Fix: move constants to a data-only sibling module (
tool-names.ts), import without re-export.index.tsnow exports functions only.typecheck clean; 19/19 tests pass.