chore(adv): land fixReviewerEvidence archive bundle on trunk#331
Merged
Conversation
Change: fixReviewerEvidence Task: tk-f0b4525a6dd8 Mode: complete Verification: Spec rq-reviewerEvidenceAuthority01 added (4 scenarios, AC1/AC2/AC5 warrants + ownership scenario). Asset test extended. TDD red→green→verify: tr_ms0u6cch (RED 7 fail), tr_ms0u6shx (GREEN 42 pass), tr_ms0u8b5f (full check clean). Engineer report submitted with durable run IDs, 0 verification warnings.
Change: fixReviewerEvidence Task: tk-feabc293e2b7 Mode: complete Verification: Policy-gate emitter fix: resolveTaskEvidence(task).policy check in verificationWarnings() adv-reviewer branch. Review-policy → return [] (no verification_missing). Test/static_check → current behavior preserved. TDD: tr_ms0uizpf (RED 1 fail), tr_ms0ujmvp (GREEN 66/66), tr_ms0ukubc (full check clean). Engineer report submitted with durable run IDs, 0 verification warnings.
Change: fixReviewerEvidence Task: tk-0c23472dfede Mode: complete Verification: Regression tests added: AC1 (review-policy no block), AC2 (test-policy block remains), AC3 (warn-first non-blocking), AC4 (change-scoped rejected). 103 gate-readiness tests pass (tr_ms0v2cg0). Full pnpm run check clean (tr_ms0v3ky5). Engineer report with durable run IDs, 0 verification warnings.
…contract IDs The acceptance gate readiness evaluator incorrectly flagged review matrix rows for out_of_scope contract items as 'unknown'. The filter checked against expectedIds (verificationRequired: true items only) instead of all contract item IDs, causing OOS rows to be rejected despite the items existing in the contract. This blocked every change with OOS contract items from completing acceptance (recurring bug observed across fixReviewerEvidence, fixOpsResolutionProjection, and likely others). Fix: check unknown rows against allContractIds (all contract items) rather than expectedIds (required items only). OOS items remain excluded from required coverage (missing check unchanged). Refs: bl-Do-akUeH
# Conflicts: # plugin/src/temporal/__tests__/archive-phase9-splitbrain.itest.ts # plugin/src/temporal/messages.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lands the in-repo archive bundle for the already-archived
fixReviewerEvidencechange onto trunk.Why
The change was merged via #330 (squash) ~18.5h before its ADV archive ran. The archive's phase9 took the noOp path (recognized the existing #330 merge proof) and skipped landing the in-repo
.adv/archive/2026-07-26-fixReviewerEvidence/bundle. The canonical bundle is durable in the external ADV store; this restores in-repo consistency with other 2026-07-26 archived changes (fixDirectArchiveRetry, hardenWorkflowRecovery both have bundles on trunk).Scope
Net diff vs trunk: 9 files, all under
.adv/archive/2026-07-26-fixReviewerEvidence/(ARCHIVE_SUMMARY, BRIEFING_DIGEST, CONTRACT_TRACEABILITY, acceptance.md, change.json, executive-summary.md, proposal.md, spec-projection.json, summary.v1.json). No code changes.No ADV lifecycle effect — the change is already
status: archivedwith release gate done (PR #330 proof).