Fix no-argument exceptions across all message event handlers - #72
Merged
Conversation
- GetCurrentKarmaReasonsHandler: fix slice to use TrimEnd().Length so '_reasons' (no trailing space) no longer throws; TrimStart() the result before splitting so '_reasons alice' still works correctly - SearchHandler, WikipediaHandler, UrbanHandler, GiphyHandler, ImageSearchHandler: same slice fix plus an explicit empty-arg guard that sends a user-friendly 'Please provide a...' message instead of silently swallowing an ArgumentOutOfRangeException - Tests: promote GetCurrentKarmaReasonsHandler no-recipient test to [Theory] covering both '_reasons' and '_reasons '; add equivalent [Theory] no-argument tests to all five mandatory-argument handler test classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'_reasons' (no trailing space) no longer throws; TrimStart() the result
before splitting so '_reasons alice' still works correctly
ImageSearchHandler: same slice fix plus an explicit empty-arg guard
that sends a user-friendly 'Please provide a...' message instead of
silently swallowing an ArgumentOutOfRangeException
[Theory] covering both '_reasons' and '_reasons '; add equivalent
[Theory] no-argument tests to all five mandatory-argument handler
test classes