Skip to content

Fix for leaderloser board handlers #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sharkwald merged 2 commits into from
Mar 17, 2026
Merged

Fix for leaderloser board handlers #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b7a0dc
Ensures no size arg is handled for leader & loserboards
Sharkwald Mar 17, 2026
e48ea18
removes push to test and always push to live on a successful CI build
Sharkwald Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/push_to_live.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
---
on:
release:
types: [created]
workflow_run:
workflows: [".NET Build and Test"]
types: [completed]
branches: [main]
name: Push to Live
jobs:
build-and-deploy:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
environment:
name: live
steps:
Expand Down
48 changes: 0 additions & 48 deletions .github/workflows/push_to_test.yml
View file
Open in desktop

This file was deleted.

8 changes: 5 additions & 3 deletions Bottomly.Tests/Slack/EventHandlers/GetLeaderBoardHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,14 @@ public void CanHandle_ValidEventWithSize_ReturnsTrue() =>
[Fact]
public void CanHandle_InvalidEvent_ReturnsFalse() => _handler.CanHandle(CreateMessage("hello")).ShouldBeFalse();

[Fact]
public async Task HandleAsync_NoSize_CallsCommandWithDefaultSize3()
[Theory]
[InlineData("_leaderboard")]
[InlineData("_leaderboard ")]
public async Task HandleAsync_NoSize_CallsCommandWithDefaultSize3(string message)
{
_mockKarmaRepo.Setup(r => r.GetLeaderBoardAsync(3)).ReturnsAsync(new List<KarmaScore>().AsReadOnly());

await _handler.HandleAsync(CreateMessage("_leaderboard "));
await _handler.HandleAsync(CreateMessage(message));

_mockKarmaRepo.Verify(r => r.GetLeaderBoardAsync(3), Times.Once());
}
Expand Down
8 changes: 5 additions & 3 deletions Bottomly.Tests/Slack/EventHandlers/GetLoserBoardHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,14 @@ public void CanHandle_ValidEventWithSize_ReturnsTrue() =>
[Fact]
public void CanHandle_InvalidEvent_ReturnsFalse() => _handler.CanHandle(CreateMessage("hello")).ShouldBeFalse();

[Fact]
public async Task HandleAsync_NoSize_CallsCommandWithDefaultSize3()
[Theory]
[InlineData("_leaderboard")]
[InlineData("_leaderboard ")]
public async Task HandleAsync_NoSize_CallsCommandWithDefaultSize3(string message)
{
_mockKarmaRepo.Setup(r => r.GetLoserBoardAsync(3)).ReturnsAsync(new List<KarmaScore>().AsReadOnly());

await _handler.HandleAsync(CreateMessage("_loserboard "));
await _handler.HandleAsync(CreateMessage(message));

_mockKarmaRepo.Verify(r => r.GetLoserBoardAsync(3), Times.Once());
}
Expand Down
2 changes: 1 addition & 1 deletion Bottomly/Slack/MessageEventHandlers/GetLeaderBoardHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class GetLeaderBoardHandler(

protected override async Task InvokeHandlerLogicAsync(MessageEvent message)
{
var sizeArg = message.Text![CommandTrigger.Length..];
var sizeArg = message.Text![CommandTrigger.Trim().Length..];
var size = int.TryParse(sizeArg, out var parsed) && parsed > 0 ? parsed : 3;

var result = await repository.GetLeaderBoardAsync(size);
Expand Down
2 changes: 1 addition & 1 deletion Bottomly/Slack/MessageEventHandlers/GetLoserBoardHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class GetLoserBoardHandler(

protected override async Task InvokeHandlerLogicAsync(MessageEvent message)
{
var sizeArg = message.Text![CommandTrigger.Length..];
var sizeArg = message.Text![CommandTrigger.Trim().Length..];
var size = int.TryParse(sizeArg, out var parsed) && parsed > 0 ? parsed : 3;

var result = await repository.GetLoserBoardAsync(size);
Expand Down
1 change: 0 additions & 1 deletion bottomly.net.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<Folder Name="/GitHubWorkflows/">
<File Path=".github/workflows/dotnet.yml" />
<File Path=".github/workflows/push_to_live.yml" />
<File Path=".github/workflows/push_to_test.yml" />
</Folder>
<Folder Name="/RepoConfig/">
<File Path=".editorconfig" />
Expand Down
Loading