Skip to content

fix(scan): drop node uptime from the live ticker#109

Merged
github-actions[bot] merged 1 commit into
mainfrom
fix/scan-drop-node-uptime
Jun 25, 2026
Merged

fix(scan): drop node uptime from the live ticker#109
github-actions[bot] merged 1 commit into
mainfrom
fix/scan-drop-node-uptime

Conversation

@satyakwok

@satyakwok satyakwok commented Jun 25, 2026

Copy link
Copy Markdown
Member

Follow-up to #108. The ticker's uptime stat was uptime_seconds from /sentrix_status, which is the serving node's process uptime since its last restart, not chain/network uptime. No major explorer shows this (Etherscan and Solscan home stats are price/market cap/transactions/gas/block; validator uptime % lives on a validators page). On a restart-heavy testnet it kept reading as wrong. Removed the item and cleaned up the now-unused status prop on LiveTicker and the useChainStatus hook in HomeContent. The other nine ticker stats are unchanged. Verified live: no uptime entry remains.

Testing: typecheck and build pass.

Summary by CodeRabbit

  • Bug Fixes
    • Simplified the live ticker display by removing the Node uptime metric.
    • The ticker now focuses on core network details like chain, block, block time, epoch progress, validators, mempool, circulating tokens, and rewards.

uptime_seconds is the serving node's process uptime since its last restart,
not chain or network uptime, and no major explorer surfaces it (Etherscan,
Solscan show price/market/tx/block stats, validator uptime lives on the
validators page). On a restart-heavy testnet it just looked wrong. Removed
the ticker item and the now-unused status prop and useChainStatus wiring.
@github-actions github-actions Bot enabled auto-merge (squash) June 25, 2026 11:14
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 28b1bdc7-0dfb-48af-9889-992fa224fd75

📥 Commits

Reviewing files that changed from the base of the PR and between 4600d0f and b2ad4c5.

📒 Files selected for processing (2)
  • apps/scan/app/[locale]/HomeContent.tsx
  • apps/scan/components/home/LiveTicker.tsx

📝 Walkthrough

Walkthrough

HomeContent no longer imports or calls useChainStatus and stops passing status to LiveTicker. LiveTicker no longer accepts status, removes the uptime formatter, and no longer renders the “Node uptime” item.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change: removing node uptime from the live ticker.
Description check ✅ Passed The description covers the change and testing, but it does not follow the template's sectioned format and lacks a clear Related section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/scan-drop-node-uptime

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: private package registry requires authentication. Disable ESLint in CodeRabbit settings or use public packages.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot merged commit 0a33461 into main Jun 25, 2026
7 checks passed
@satyakwok satyakwok deleted the fix/scan-drop-node-uptime branch June 25, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant