Skip to content

fix(scan): error states for token detail, richlist, and active accounts #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Jun 25, 2026
Merged

fix(scan): error states for token detail, richlist, and active accounts #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/scan/app/[locale]/leaderboard/account/active/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { Skeleton } from "@/components/ui/skeleton";
import { Address } from "@/components/common/Address";
import { Pagination } from "@/components/common/Pagination";
import { RankBadge } from "@/components/common/RankBadge";
import { FetchError } from "@/components/common/FetchError";
import { useNetwork, useNetworkFromQuery } from "@/lib/network-context";
import { useActiveAccounts } from "@/lib/hooks";
import { formatNumber } from "@/lib/format";
Expand All @@ -16,7 +17,7 @@ const PAGE_SIZE = 25;
export default function MostActiveAccountsPage() {
const { network } = useNetwork();
useNetworkFromQuery();
const { data: accounts, loading } = useActiveAccounts(network, 100);
const { data: accounts, loading, error, retry } = useActiveAccounts(network, 100);
const [page, setPage] = useState(1);

const totalPages = Math.max(1, Math.ceil((accounts?.length ?? 0) / PAGE_SIZE));
Expand All @@ -39,6 +40,8 @@ export default function MostActiveAccountsPage() {
<Skeleton key={i} className="h-12 w-full" style={{ opacity: 1 - i * 0.08 }} />
))}
</div>
) : error ? (
<FetchError onRetry={retry} />
) : (accounts?.length ?? 0) === 0 ? (
<div className="p-12 text-center">
<Activity className="h-8 w-8 text-muted-foreground/40 mx-auto mb-2" />
Expand Down
5 changes: 4 additions & 1 deletion apps/scan/app/[locale]/leaderboard/account/holders/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { Skeleton } from "@/components/ui/skeleton";
import { Address } from "@/components/common/Address";
import { Pagination } from "@/components/common/Pagination";
import { RankBadge } from "@/components/common/RankBadge";
import { FetchError } from "@/components/common/FetchError";
import { useNetwork, useNetworkFromQuery } from "@/lib/network-context";
import { useRichlist, useValidators } from "@/lib/hooks";
import { formatNumber } from "@/lib/format";
Expand All @@ -17,7 +18,7 @@ const PAGE_SIZE = 25;
export default function TopHoldersPage() {
const { network } = useNetwork();
useNetworkFromQuery();
const { data: holders, loading } = useRichlist(network, 100);
const { data: holders, loading, error, retry } = useRichlist(network, 100);
const { data: validators } = useValidators(network);
const [sortKey, setSortKey] = useState<SortKey>("balance");
const [sortDir, setSortDir] = useState<"asc" | "desc">("desc");
Expand Down Expand Up @@ -57,6 +58,8 @@ export default function TopHoldersPage() {
<div className="p-4 space-y-2">
{Array.from({ length: 10 }).map((_, i) => <Skeleton key={i} className="h-12 w-full" style={{ opacity: 1 - i * 0.08 }} />)}
</div>
) : error ? (
<FetchError onRetry={retry} />
) : sorted.length === 0 ? (
<div className="p-12 text-center">
<Trophy className="h-8 w-8 text-muted-foreground/40 mx-auto mb-2" />
Expand Down
5 changes: 4 additions & 1 deletion apps/scan/app/[locale]/leaderboard/whale/top/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Card, CardContent } from "@/components/ui/card";
import { Skeleton } from "@/components/ui/skeleton";
import { Address } from "@/components/common/Address";
import { EmptyState } from "@/components/common/EmptyState";
import { FetchError } from "@/components/common/FetchError";
import { RankBadge } from "@/components/common/RankBadge";
import { useNetwork, useNetworkFromQuery } from "@/lib/network-context";
import { useRichlist, useValidators } from "@/lib/hooks";
Expand All @@ -18,7 +19,7 @@ const DEFAULT_THRESHOLD = 100_000; // SRX
export default function WhaleTopWalletsPage() {
const { network } = useNetwork();
useNetworkFromQuery();
const { data: holders, loading } = useRichlist(network, 100);
const { data: holders, loading, error, retry } = useRichlist(network, 100);
const { data: validators } = useValidators(network);
const [threshold, setThreshold] = useState(DEFAULT_THRESHOLD);

Expand Down Expand Up @@ -60,6 +61,8 @@ export default function WhaleTopWalletsPage() {
<div className="p-4 space-y-2">
{Array.from({ length: 6 }).map((_, i) => <Skeleton key={i} className="h-12 w-full" style={{ opacity: 1 - i * 0.1 }} />)}
</div>
) : error ? (
<FetchError onRetry={retry} />
) : whales.length === 0 ? (
<EmptyState
icon={Fish}
Expand Down
9 changes: 7 additions & 2 deletions apps/scan/app/[locale]/tokens/[addr]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { Card, CardContent } from "@/components/ui/card";
import { Skeleton } from "@/components/ui/skeleton";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import { Address } from "@/components/common/Address";
import { FetchError } from "@/components/common/FetchError";
import { TxHash } from "@/components/common/TxHash";
import { Timestamp } from "@/components/common/Timestamp";
import { InfoRow } from "@/components/common/InfoRow";
Expand Down Expand Up @@ -37,8 +38,8 @@ export default function TokenDetailPage({ params }: { params: Promise<{ addr: st
const otherNetwork = network === "mainnet" ? "testnet" : "mainnet";
const [tokenOther, setTokenOther] = useState<TokenData | null>(null);
const [loadingOther, setLoadingOther] = useState(true);
const { data: holders, loading: holdersLoading } = useTokenHolders(network, addr, 50);
const { data: trades, loading: tradesLoading } = useTokenTrades(network, addr, 1, 25);
const { data: holders, loading: holdersLoading, error: holdersError, retry: retryHolders } = useTokenHolders(network, addr, 50);
const { data: trades, loading: tradesLoading, error: tradesError, retry: retryTrades } = useTokenTrades(network, addr, 1, 25);

useEffect(() => {
setLoading(true);
Expand Down Expand Up @@ -153,6 +154,8 @@ export default function TokenDetailPage({ params }: { params: Promise<{ addr: st
<div className="p-4 space-y-2">
{Array.from({ length: 6 }).map((_, i) => <Skeleton key={i} className="h-12 w-full" />)}
</div>
) : tradesError ? (
<FetchError onRetry={retryTrades} />
) : trades && trades.length > 0 ? (
<div className="overflow-x-auto">
<table className="w-full text-sm">
Expand Down Expand Up @@ -201,6 +204,8 @@ export default function TokenDetailPage({ params }: { params: Promise<{ addr: st
<div className="p-4 space-y-2">
{Array.from({ length: 6 }).map((_, i) => <Skeleton key={i} className="h-12 w-full" />)}
</div>
) : holdersError ? (
<FetchError onRetry={retryHolders} />
) : holders && holders.length > 0 ? (
<div className="overflow-x-auto">
<table className="w-full text-sm">
Expand Down
20 changes: 12 additions & 8 deletions apps/scan/lib/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,9 +971,10 @@ interface RawRichlistEntry {
percent_of_supply?: number;
}

export async function fetchRichlist(network: NetworkId, limit = 100): Promise<TopHolder[]> {
export async function fetchRichlist(network: NetworkId, limit = 100): Promise<TopHolder[] | null> {
const res = await apiFetch<{ holders: RawRichlistEntry[] }>(network, `/richlist?limit=${limit}`);
if (!res?.holders) return [];
if (res === null) return null;
if (!res.holders) return [];
return res.holders.map((h, i) => ({
rank: i + 1,
address: h.address,
Expand All @@ -994,12 +995,13 @@ export async function fetchTokenHolders(
network: NetworkId,
contract: string,
limit = 50,
): Promise<TokenHolder[]> {
): Promise<TokenHolder[] | null> {
const res = await apiFetch<{ holders: RawTokenHolder[] }>(
network,
`/tokens/${normalizeAddress(contract)}/holders?limit=${limit}`,
);
if (!res?.holders) return [];
if (res === null) return null;
if (!res.holders) return [];
return res.holders.map((h) => ({
address: h.address,
// 2026-04-30 audit: balance_sentri is the raw 1e8-scaled value; older
Expand All @@ -1026,13 +1028,14 @@ export async function fetchTokenTrades(
contract: string,
page = 1,
limit = 20,
): Promise<TokenTransfer[]> {
): Promise<TokenTransfer[] | null> {
const offset = (page - 1) * limit;
const res = await apiFetch<{ trades: RawTokenTrade[] }>(
network,
`/tokens/${normalizeAddress(contract)}/trades?limit=${limit}&offset=${offset}`,
);
if (!res?.trades) return [];
if (res === null) return null;
if (!res.trades) return [];
return res.trades.map((t) => ({
tx_hash: t.txid ?? t.tx_hash ?? "",
from: t.from,
Expand Down Expand Up @@ -1400,9 +1403,10 @@ export interface ActiveAccount {
tx_count: number;
}

export async function fetchActiveAccounts(network: NetworkId, limit = 100): Promise<ActiveAccount[]> {
export async function fetchActiveAccounts(network: NetworkId, limit = 100): Promise<ActiveAccount[] | null> {
const res = await apiFetch<{ accounts: ActiveAccount[] }>(network, `/accounts/active?limit=${limit}`);
return res?.accounts ?? [];
if (res === null) return null;
return res.accounts ?? [];
}

// ── /contracts/recent ───────────────────────────────────────────────────────
Expand Down
Loading