feat(code-quality): add --exclude flag to /code-quality:size - #32
Open
bfirestone wants to merge 1 commit into
Open
feat(code-quality): add --exclude flag to /code-quality:size#32bfirestone wants to merge 1 commit into
bfirestone wants to merge 1 commit into
Conversation
Let users pass ad-hoc exclusion globs at invocation time without editing repo config. The flag augments (does not replace) the three existing exclusion sources: bundled universal defaults, repo-local .code-quality/size-review-exclude, and .gitattributes linguist-generated=true. - commands/size.md: document the new `/code-quality:size <scope> --exclude <pattern>` invocation form - skills/size-review/SKILL.md: add invocation-supplied patterns as a fourth exclusion source in the union Useful for one-off local reviews where you want to ignore a vendored or generated directory without modifying tracked config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CLI-supplied
--exclude <pattern>flag to/code-quality:sizeso users can pass ad-hoc exclusion globs at invocation time without editing tracked repo config. Useful for one-off local reviews where a vendored or generated directory should be ignored just this once.The flag augments (does not replace) the three existing exclusion sources, becoming a fourth source in the union:
references/default-exclusions.md).code-quality/size-review-exclude.gitattributeslinguist-generated=true--exclude <pattern>(one or more)Changes
commands/size.md— document the new/code-quality:size <scope> --exclude <pattern>invocation form and the quoting rule for patterns containing spaces.skills/size-review/SKILL.md— add invocation-supplied patterns as the fourth source in the exclusion-build step; updated the section header from "up to three sources" to "these sources".No behavior change for invocations that don't pass
--exclude. Backward compatible with existing repos.Test plan
/code-quality:sizeon a branch without--excludebehaves identically to before (the new source is empty)./code-quality:size #<PR> --exclude "vendor/**"removesvendor/**from the threshold check and seam analysis on top of bundled + repo-local +.gitattributesexclusions.--exclude "generated stubs/**") is parsed as a single argument when quoted.