Improve the usability of PDF file#148
Open
tcvan0707 wants to merge 1 commit into
Open
Conversation
* Remove artifact On-this-page and Edit-this-page * Fixed image does not show properly
Contributor
|
Can you drag on drop the pdf here? |
Author
|
Contributor
|
Can you also change the name of the PR to something more descriptive |
Contributor
|
This is getting better! I'd love to go further (here or in another PR). Can we do some CSS Print specific styles? |
Author
I changed it. Thank you. |
Contributor
|
I skimmed the first article and that potentially could be the answer to some tables not fitting the pdf issue. @tcvan0707 |
Contributor
|
NOTE: I'm happy for some of this to happen in follow up PRs. We don't have to wait for it to be perfect before we merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #65, I have improved some of the content in this pull request.
I remove the web-only artifacts like "On this page" and "Edit this page", since we do not want it inside our PDF file.
And another thing is I have adjust some pictures not showing properly in PDF file, for example
and this is when after adjusting 
On the other hand, some tables are still not fit the PDF page yet,
ASCII Collating Sequencefor example, and tables undertypes.mdas well. I will file an issue on that, so we can work on it later.