Skip to content

refactor: remove supabase, add postgres, fix tests#3807

Draft
chrispinkney wants to merge 1 commit into
Seneca-CDOT:masterfrom
manekenpix:remove-supabase
Draft

refactor: remove supabase, add postgres, fix tests#3807
chrispinkney wants to merge 1 commit into
Seneca-CDOT:masterfrom
manekenpix:remove-supabase

Conversation

@chrispinkney

@chrispinkney chrispinkney commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

Co-authored-by: Josue manekenpix@fastmail.com

Issue This PR Addresses

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@chrispinkney chrispinkney self-assigned this Apr 11, 2023
@manekenpix manekenpix changed the title refactor: remove supabase, add postgres, fixed tests refactor: remove supabase, add postgres, fix tests Apr 11, 2023
@manekenpix manekenpix self-assigned this Apr 11, 2023
@manekenpix manekenpix added area: supabase Anything related to Supabase area: database Postgres db labels Apr 11, 2023
humphd
humphd requested changes Apr 11, 2023
View reviewed changes

@humphd humphd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful to see happening! So glad to see you two deleting all this code, thank you! We need to delete 10x this much :)

What are we going to do about other users of Supabase, for example: https://github.com/Seneca-CDOT/telescope/blob/d5b23e42523521f49fc77d1b76e3f408dd9a46d1/src/web/app/src/supabase.ts

Comment thread src/api/parser/env.local

# Supabase Secrets
SUPABASE_URL=http://localhost/v1/supabase
SUPABASE_URL="postgresql://postgres:your-super-secret-and-long-postgres-password@localhost/postgres"

@humphd humphd Apr 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATABASE_URL?

Comment thread src/api/parser/env.local
# Supabase Secrets
SUPABASE_URL=http://localhost/v1/supabase
SUPABASE_URL="postgresql://postgres:your-super-secret-and-long-postgres-password@localhost/postgres"
SERVICE_ROLE_KEY=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyAgCiAgICAicm9sZSI6ICJzZXJ2aWNlX3JvbGUiLAogICAgImlzcyI6ICJzdXBhYmFzZS1kZW1vIiwKICAgICJpYXQiOiAxNjQxNzY5MjAwLAogICAgImV4cCI6IDE3OTk1MzU2MDAKfQ.DaYlNEoUrrEn2Ig7tqibS-PHK5vgusbcbo7X36XVt4Q

@humphd humphd Apr 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These other vestiges of Supabase, can they go too?

Comment thread src/api/parser/src/utils/db.js
},
});

if (!SUPABASE_URL || !SERVICE_ROLE_KEY) {

@humphd humphd Apr 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this up, since you use the URL variable earler

Comment thread src/api/parser/Dockerfile

COPY package.json ./

COPY ./schema.prisma .

@humphd humphd Apr 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this file?

@humphd

humphd commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

I won't bug you with reviews until you're ready. Let me know.

@manekenpix @chrispinkney
refactor: remove supabase, add postgres, fixed tests
6577b61 
Co-authored-by: Josue <manekenpix@fastmail.com>
@chrispinkney

chrispinkney commented Apr 11, 2023

Copy link
Copy Markdown
Contributor Author

I won't bug you with reviews until you're ready. Let me know.

@humphd Finishing work on parser, @manekenpix is working on the SSO stuff- we're using this PR for both. Should be done soon! We don't think the supabase stuff in the frontend is being used by anything and will probably remove it. 😀

@humphd

humphd commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

I won't bug you with reviews until you're ready. Let me know.

@humphd Finishing work on parser, @manekenpix is working on the SSO stuff- we're using this PR for both. Should be done soon! We don't think the supabase stuff in the frontend is being used by anything and will probably remove it. 😀

Fantastic, thanks for the update. Really glad for your help with this. Thank you both!

@TDDR TDDR mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humphd humphd humphd requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@chrispinkney chrispinkney

@manekenpix manekenpix

Labels

area: database Postgres db area: supabase Anything related to Supabase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrispinkney @humphd @manekenpix