Skip to content

chore: upgrade passport to v0.6.0#3669

Closed
manekenpix wants to merge 1 commit into
Seneca-CDOT:masterfrom
manekenpix:update-passport
Closed

chore: upgrade passport to v0.6.0#3669
manekenpix wants to merge 1 commit into
Seneca-CDOT:masterfrom
manekenpix:update-passport

Conversation

@manekenpix

@manekenpix manekenpix commented Oct 3, 2022

Copy link
Copy Markdown
Member

Description

This PR is a fix for #3636. I broke pnpm-lock.yaml when I was trying to fix the conflicts after merging #3642.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix added the dependencies Pull requests that update a dependency file label Oct 3, 2022
@manekenpix manekenpix requested a review from humphd October 3, 2022 04:40
@manekenpix manekenpix self-assigned this Oct 3, 2022
@gitpod-io

gitpod-io Bot commented Oct 3, 2022

Copy link
Copy Markdown

@manekenpix manekenpix marked this pull request as ready for review October 3, 2022 04:59
humphd
humphd previously approved these changes Oct 3, 2022
View reviewed changes
@manekenpix manekenpix marked this pull request as draft October 3, 2022 16:06
@manekenpix manekenpix marked this pull request as ready for review October 4, 2022 04:28
@manekenpix manekenpix mentioned this pull request Oct 4, 2022
Closed
1 task
@humphd

humphd commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

This failure is annoying, but I haven't had time to dig into it. Probably getting my e2e auth rewrite PR finished would fix it.

@manekenpix

manekenpix commented Nov 1, 2022

Copy link
Copy Markdown
Member Author

This failure is annoying, but I haven't had time to dig into it. Probably getting my e2e auth rewrite PR finished would fix it.

@humphd I'm not even sure if it's us. I checked passport's issues and it seems that version 0.6 is causing problems, but I can't tell if that's what's making our e2es fail. I'm doing some testing to see if I can find something, but I don't even know what I'm supposed to find.

@manekenpix manekenpix force-pushed the master branch 16 times, most recently from 94eec21 to e27efa5 Compare December 3, 2022 21:12
@manekenpix

manekenpix commented Dec 3, 2022

Copy link
Copy Markdown
Member Author

This will be fixed in #3568

@manekenpix manekenpix closed this Dec 3, 2022
@manekenpix manekenpix deleted the update-passport branch December 3, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humphd humphd humphd left review comments

Assignees

@manekenpix manekenpix

Labels

dependencies Pull requests that update a dependency file hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manekenpix @humphd