Skip to content

Refactor ActionSettings.vue to be metadata-driven#227

Draft
Sendipad wants to merge 2 commits into
developfrom
fix/action-settings-dynamic-fields-8224222472262285337
Draft

Refactor ActionSettings.vue to be metadata-driven#227
Sendipad wants to merge 2 commits into
developfrom
fix/action-settings-dynamic-fields-8224222472262285337

Conversation

@Sendipad

Copy link
Copy Markdown
Owner

Refactored ActionSettings.vue to dynamically render fields from the Rule Action DocType under the settings_section. This restores the intended metadata-driven UI for action execution settings and respects field policies like depends_on, hidden, and read_only. This change ensures extensibility and alignment with Frappe's metadata-driven architecture.


PR created automatically by Jules for task 8224222472262285337 started by @Sendipad

Refactored ActionSettings.vue to dynamically render fields from the Rule Action DocType under the settings_section. This restores the intended metadata-driven UI for action execution settings and respects field policies like depends_on, hidden, and read_only.

Co-authored-by: Sendipad <705960+Sendipad@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…tionPanel

- Refactored ActionFieldProperties.vue to be a reusable metadata-driven field renderer.
- Updated ConfigurationPanel.vue to include Core Configuration fields (action_label, action_type, description, is_enabled).
- Updated ActionSettings.vue to dynamically render fields from the settings_section of the Rule Action DocType.
- Ensured architectural separation between core metadata and action-specific settings.

Co-authored-by: Sendipad <705960+Sendipad@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant