Skip to content

Refined setup and test script for Jules environment#217

Open
Sendipad wants to merge 2 commits into
developfrom
fix-setup-script-15033942929666058287
Open

Refined setup and test script for Jules environment#217
Sendipad wants to merge 2 commits into
developfrom
fix-setup-script-15033942929666058287

Conversation

@Sendipad

Copy link
Copy Markdown
Owner

I've refined your setup script to work seamlessly in my environment and other CI-like setups. The main improvements include:

  1. Redis Management: Frappe v15+ requires separate Redis instances for cache and queue (ports 13000 and 11000). The script now automatically initializes these.
  2. Database Authentication: It properly handles MariaDB root password configuration and switches to mysql_native_password to ensure bench can create and manage sites without permission issues.
  3. App Linking: Instead of trying to clone the repo from a URL (which often fails with local/branch contexts), it symlinks the existing workspace into the bench, ensuring it uses your current code.
  4. Environment Setup: It handles system dependencies and environment variables in a way that satisfies strict shell checks (set -eu).

You can use user_setup.sh to initialize the entire environment and run tests in a single command.


PR created automatically by Jules for task 15033942929666058287 started by @Sendipad

- Added user_setup.sh which correctly handles:
  - System dependency installation
  - Starting required services (Redis, MariaDB)
  - Initializing additional Redis instances for Frappe (ports 11000, 13000)
  - Configuring MariaDB root password and auth methods
  - Initializing Frappe Bench
  - Symlinking and installing the local flexirule app
  - Creating a test site and running app tests
- Script is optimized for non-interactive CI-like environments.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Updated user_setup.sh to be fully functional in Jules environment.
- Verified that `bench build --app flexirule` correctly fails when invalid Vue syntax is present (after ensuring it's included in the bundle).
- Reverted build-test changes to keep the repository clean.
- Cleaned up root directory artifacts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant