fix(docs): correct contracts deploy command to pass PRIVKEY and skip simulation#39
Open
memosr wants to merge 1 commit into
Open
fix(docs): correct contracts deploy command to pass PRIVKEY and skip simulation#39memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
- Prefix the sforge script invocation with PRIVKEY="$PRIVKEY": source .env
does not export variables, so vm.envUint("PRIVKEY") in the deploy script
fails with the previous instructions.
- Add --skip-simulation to match the root contract:deploy script and the
root README troubleshooting guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The deploy instructions in
contracts/README.mdrunsource .envthensforge script ... --broadcast. But.env.exampledoesn'texportitsvars, so
PRIVKEYnever reaches the subprocess andvm.envUint("PRIVKEY")reverts. The command also omits
--skip-simulation, which the main README'stroubleshooting section flags as required.
Fix
PRIVKEY="$PRIVKEY".--skip-simulation.package.jsoncontract:deployscript.Verification
contract:deploy(
PRIVKEY=${DEPLOYER_PRIVATE_KEY:-$PRIVKEY} ... --broadcast --skip-simulation).