fix(attestation): reject malformed certificate data safely#204
Draft
Alicepoltora wants to merge 1 commit into
Draft
fix(attestation): reject malformed certificate data safely#204Alicepoltora wants to merge 1 commit into
Alicepoltora wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The attestation endpoint already validates the outer DCAP quote, but the nested QE/PCK certificate data was still parsed with unchecked
unwrap,expect,assert, and direct indexing. A malformed quote could therefore panic the enclave while extracting the FMSPC and issuer before PCCS verification.This change:
dcap-rsnested parser as defense in depth;Impact
Malformed attestation evidence now returns a JSON-RPC error instead of terminating the enclave server. Valid certificate extraction and PCCS verification behavior is unchanged.
Verification
cargo fmt --all --checkcargo test -p seismic-enclave-server --lib(10 passed)The full package test command compiles successfully; its privileged bootstrap integration test is skipped/fails in this environment because it requires sudo.