refactor: split manifest schema into a seismic-network-manifest crate#200
Merged
Conversation
NetworkManifestV1 / NetworkId / ManifestError move out of seismic-attestation into a dependency-light crate (serde + sha2, no attested-tls) so every manifest consumer parses with the same code. tdx-init previously hand-mirrored the schema — two strict parsers kept in lockstep by a shared fixture, a standing split-brain risk for a security identifier — because depending on seismic-attestation would have dragged the attestation stack into the boot binary. It now validates via the shared crate, and the mirror and its lockstep tests are deleted. The same crate is what deploy-side tooling can reuse later to retire the Python mirror. seismic-attestation re-exports the types, so node-side callers (enclave-server, the transcript bindings) are unchanged. The golden fixture moves with the schema; the deploy repo's drift guard and Python mirror get repointed at the new path separately, once this is pushed. Also removes a stale phase label from enclave-server's bootstrap module doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkManifestV1 / NetworkId / ManifestError move out of seismic-attestation into a dependency-light crate (serde + sha2, no attested-tls) so every manifest consumer parses with the same code. tdx-init previously hand-mirrored the schema — two strict parsers kept in lockstep by a shared fixture, a standing split-brain risk for a security identifier — because depending on seismic-attestation would have dragged the attestation stack into the boot binary. It now validates via the shared crate, and the mirror and its lockstep tests are deleted. The same crate is what deploy-side tooling can reuse later to retire the Python mirror.
seismic-attestation re-exports the types, so node-side callers (enclave-server, the transcript bindings) are unchanged. The golden fixture moves with the schema; the deploy repo's drift guard and Python mirror get repointed at the new path separately, once this is pushed.
Also removes a stale phase label from enclave-server's bootstrap module doc.