feat(tdx-init)!: require [network] manifest in InitConfig#197
Merged
Conversation
`network` was Option<NetworkConfig>, so a POST without [network] was accepted (200) — but enclave-server hard-requires network-manifest.json at startup (it derives network_id and binds every attestation to it) and is fatal without it. The node then crash-looped at boot, with the cause visible only in journalctl. Make `network` required so toml::from_str rejects a manifest-less POST with 400 at deploy time — loud and actionable — instead of a silent boot-time crash-loop. server and writer drop their `if let Some(..)` guards and validate/write the manifest unconditionally. The deploy CLI (seismic-tee configure) merges the network-wide manifest into the per-node config at POST time, so [network] is always present on the wire.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
networkwas Option, so a POST without [network] was accepted (200) — but enclave-server hard-requires network-manifest.json at startup (it derives network_id and binds every attestation to it) and is fatal without it. The node then crash-looped at boot, with the cause visible only in journalctl.Make
networkrequired so toml::from_str rejects a manifest-less POST with 400 at deploy time — loud and actionable — instead of a silent boot-time crash-loop. server and writer drop theirif let Some(..)guards and validate/write the manifest unconditionally.The deploy CLI (seismic-tee configure) merges the network-wide manifest into the per-node config at POST time, so [network] is always present on the wire.