Skip to content

Move T3 charge calculation#211

Closed
jchismar wants to merge 1 commit into
masterfrom
charge_calc_order
Closed

Move T3 charge calculation#211
jchismar wants to merge 1 commit into
masterfrom
charge_calc_order

Conversation

@jchismar

@jchismar jchismar commented Nov 3, 2025

Copy link
Copy Markdown

This PR moves the T3 charge calculation up to avoid early exits where the charge does not get calculated.

@jchismar

jchismar commented Nov 3, 2025

Copy link
Copy Markdown
Author

/run all

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
 (target branch)
 (this PR)

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@slava77

slava77 commented Nov 3, 2025

Copy link
Copy Markdown

Here is a timing comparison:

the result is empty; is it a glitch or did something go bad in the CI

@slava77

slava77 commented Nov 3, 2025

Copy link
Copy Markdown

/run standalone

@slava77

slava77 commented Nov 3, 2025

Copy link
Copy Markdown

@jchismar
there are no visible differences. So, I think it's OK to keep the fix inside the T4 PR.

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
 (target branch)
 (this PR)

@slava77

slava77 commented Nov 3, 2025

Copy link
Copy Markdown
image

still empty
@ariostas please check the CI side

@jchismar

jchismar commented Nov 4, 2025

Copy link
Copy Markdown
Author

This fix will be included in #189

@jchismar jchismar closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants