fix: audit follow-ups — docs truth, wire bugs, release CI gate - #1
Merged
Conversation
Pre-rollout audit fixes (no behavior change to the happy path): - README: correct the tier story (free keys work; Radar gates the negotiation playbook + full feed depth), document all 19 tools (adds check_new_matches + the 3 match-review tools), fix the dead `cd mcp-server` dev path. - __init__.py: version 0.2.2 -> 0.3.1 (match pyproject). - server docstring: "sixteen tools" -> "nineteen". - list_questions: wrap the endpoint's bare-list response in a dict so FastMCP return-validation stops rejecting it on real data. - update_application: report each write leg independently + a `partial` flag, so a committed status change isn't hidden behind a note-write failure (which caused silent double-applies on retry). - check_new_matches: document that it scans the first page only. - httpx client: close the pool on interpreter exit (atexit). - release.yml: gate the PyPI publish on the test suite — a red build can no longer publish (this is how v0.3.0 shipped dead tools). - tests: cover update_application (both-succeed / partial / no-args) and the list_questions list-wrapping. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Bmmmgcida7VUntvBm16Xt
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-rollout audit fixes. Companion PR in the backend (
epd11183/JobSearch) adds PAT brute-force rate-limiting + the activate-from-Claude spec.What
check_new_matches+ the 3 match-review tools); deadcd mcp-serverdev path removed. Explicit push-vs-pull note forcheck_new_matches.__init__.pyversion0.2.2→0.3.1(matchespyproject); module docstring "sixteen tools" → "nineteen".list_questionswraps the endpoint's bare-list response in a dict so FastMCP return-validation stops rejecting it on real data (live-smoke failure).update_applicationreports each write leg independently + apartialflag, so a committed status change isn't hidden behind a note-write failure (which caused silent double-applies on retry).check_new_matchesdocuments that it scans the first page only.atexit).release.ymlgates the PyPI publish on the test suite — a red build can no longer publish (this is how v0.3.0 shipped dead tools).Tests
62 pass (was 58). New coverage:
update_application(both-succeed / partial / no-args) andlist_questionslist-wrapping.🤖 Generated with Claude Code