Skip to content

feat: adapt 26.30#1

Merged
DivanadiumPentaoxide merged 7 commits into
mainfrom
feat-logger
Jun 21, 2026
Merged

feat: adapt 26.30#1
DivanadiumPentaoxide merged 7 commits into
mainfrom
feat-logger

Conversation

@DivanadiumPentaoxide

Copy link
Copy Markdown
Contributor
  • 26.30 (v1001) support.
  • Add logger (WIP)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial support for Bedrock 26.30 (v1001) while introducing a new asynchronous sculk::Logger and migrating runtime console output from std::println calls to the logger.

Changes:

  • Introduce sculk::Logger (async backend + file output) and migrate runtime logging in Main.cpp and ProxyPass.cpp.
  • Add configurable packet-parse-error logging (packets_logger.log_parse_error) and wire parse-failure callbacks.
  • Add LoggerTests executable + CTest registration; update README protocol badge to v1001 / 26.30.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tests/LoggerTests.cpp New logger behavioral tests (flush, setFile switch, multithread).
src/ProxySettings.hpp Adds packets_logger.log_parse_error setting.
src/ProxyPass.hpp Includes logger header for use by proxy pass.
src/ProxyPass.cpp Replaces std::println with Logger and adds parse-failed logging hooks; updates session access to .lock().
src/Main.cpp Initializes logger file and replaces startup/shutdown prints with Logger.
src/Logger.hpp Declares new sculk::Logger API.
src/Logger.cpp Implements async logger backend (queue + worker thread), console color formatting, file output.
README.md Updates protocol badge to v1001 / 26.30.
README.zh.md Updates protocol badge to v1001 / 26.30.
CMakeLists.txt Adds testing support + LoggerTests target; fetches concurrentqueue dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/LoggerTests.cpp
Comment thread tests/LoggerTests.cpp
Comment thread src/ProxyPass.hpp Outdated
Comment thread src/ProxyPass.cpp Outdated
Comment thread src/Logger.cpp
Comment thread src/Logger.cpp
Comment thread src/Logger.cpp Outdated
@DivanadiumPentaoxide DivanadiumPentaoxide merged commit ba945a1 into main Jun 21, 2026
2 checks passed
@DivanadiumPentaoxide DivanadiumPentaoxide deleted the feat-logger branch June 21, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants