feat: adapt 26.30#1
Merged
Merged
Conversation
DivanadiumPentaoxide
commented
Jun 20, 2026
Contributor
- 26.30 (v1001) support.
- Add logger (WIP)
There was a problem hiding this comment.
Pull request overview
Adds initial support for Bedrock 26.30 (v1001) while introducing a new asynchronous sculk::Logger and migrating runtime console output from std::println calls to the logger.
Changes:
- Introduce
sculk::Logger(async backend + file output) and migrate runtime logging inMain.cppandProxyPass.cpp. - Add configurable packet-parse-error logging (
packets_logger.log_parse_error) and wire parse-failure callbacks. - Add
LoggerTestsexecutable + CTest registration; update README protocol badge to v1001 / 26.30.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/LoggerTests.cpp | New logger behavioral tests (flush, setFile switch, multithread). |
| src/ProxySettings.hpp | Adds packets_logger.log_parse_error setting. |
| src/ProxyPass.hpp | Includes logger header for use by proxy pass. |
| src/ProxyPass.cpp | Replaces std::println with Logger and adds parse-failed logging hooks; updates session access to .lock(). |
| src/Main.cpp | Initializes logger file and replaces startup/shutdown prints with Logger. |
| src/Logger.hpp | Declares new sculk::Logger API. |
| src/Logger.cpp | Implements async logger backend (queue + worker thread), console color formatting, file output. |
| README.md | Updates protocol badge to v1001 / 26.30. |
| README.zh.md | Updates protocol badge to v1001 / 26.30. |
| CMakeLists.txt | Adds testing support + LoggerTests target; fetches concurrentqueue dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.