fix(rpi-imager): tag images with hardware devices so Imager lists them#3090
Open
vpetersson wants to merge 1 commit into
Open
fix(rpi-imager): tag images with hardware devices so Imager lists them#3090vpetersson wants to merge 1 commit into
vpetersson wants to merge 1 commit into
Conversation
- add a `devices` hardware tag to every entry; without it Imager's exclusive-matching devices (e.g. the Pi 5) silently drop the entry, hiding Anthias entirely once a Pi 5 is selected - hide the 32-bit armhf `pi3` stream from Imager (still built and directly downloadable); steer Pi 3 users to the `pi3-64` Qt6 stream - warn (non-fatal) in the website deploy when an entry lacks `devices` - update tests and README Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Raspberry Pi Imager JSON generator and related CI/docs so Anthias entries are discoverable in Raspberry Pi Imager 2.x by tagging each OS entry with the appropriate hardware devices tags (and hiding the legacy 32-bit Pi 3 stream from Imager).
Changes:
- Add board→Imager-hardware-tag mapping and emit
devicesfor each generated OS entry; requiredevicesin the generator’s required-field set. - Remove 32-bit
pi3from the Imager-supported board set (while keeping mapping/suffix behavior available if it’s ever re-listed). - Add tests/docs updates and a non-fatal deploy-time warning if release
rpi-imager.jsonlacksdevices.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/raspberry_pi_imager/build_pi_imager_json.py | Adds BOARD_DEVICE_TAGS, emits devices, updates supported boards and required fields. |
| tools/raspberry_pi_imager/tests/test_build_pi_imager_json.py | Extends unit tests to cover device tagging and hiding 32-bit Pi 3. |
| tools/raspberry_pi_imager/README.md | Updates supported boards list and explains why 32-bit Pi 3 is not listed in Imager. |
| .github/workflows/deploy-website.yaml | Adds a deploy-time jq warning for missing/empty devices arrays in the release asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
+31
| 4. Patches URLs and file sizes, tags each entry with its hardware | ||
| `devices` (so Imager's device picker doesn't hide it), and appends a | ||
| maintenance mode notice for pi2/pi3 |
| if ! jq -e '[.os_list[] | | ||
| (.devices | type == "array") and (.devices | length > 0)] | ||
| | all' "$out" > /dev/null; then | ||
| echo "::warning::rpi-imager.json has entries without a non-empty 'devices' tag; Imager may hide them on exclusive-matching devices (e.g. Pi 5). This release predates the devices change — re-cut a release." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Anthias not appearing in Raspberry Pi Imager. The current Imager (2.x) makes you pick a device first, then filters the OS list by each entry's
deviceshardware tags. Anthias's entries carried nodevicesarray, and the Raspberry Pi 5 device usesmatching_type: "exclusive", which drops untagged entries (filterOsListWithHWTagsinrpi-imager/src/imagewriter.cpp). With all 5 Anthias subitems untagged, the parent "Anthias" category filters down to 0 children and disappears entirely when a Pi 5 is selected.Description
deviceshardware tag to every entry the generator emits (pi2→pi2-32bit,pi3-64→pi3-64bit,pi4-64→pi4-64bit,pi5→pi5-64bit), so Imager's device picker no longer hides them.pi3stream from Imager. The image is still built and remains directly downloadable from the release; Pi 3 users are steered to the 64-bit Qt6pi3-64stream.devices(a hard gate would block every deploy until the next release is cut, since the current release asset predates this change).Note
This fixes the generated feed. The official catalog (
os_list_imagingutility_v4.json) currently inlines Anthias's entries as a stale snapshot, so the v4 list stays untagged until Raspberry Pi re-syncs after a new release ships. Thev3catalog pulls our feed live viasubitems_urland will pick this up automatically.Checklist
🤖 Generated with Claude Code