Skip to content

easyroam: add version 1.4.7#582

Open
tie-ling wants to merge 2 commits into
ScoopInstaller:masterfrom
tie-ling:easyroam
Open

easyroam: add version 1.4.7#582
tie-ling wants to merge 2 commits into
ScoopInstaller:masterfrom
tie-ling:easyroam

Conversation

@tie-ling

@tie-ling tie-ling commented May 6, 2026

Copy link
Copy Markdown

Closes #581

Closes #XXXX

Relates to #XXXX

Summary by CodeRabbit

  • Chores
    • Added Windows package manifest for Scoop package manager installation support.

Closes ScoopInstaller#581

Signed-off-by: Yan Cao <git@apvc.uk>
@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown

Walkthrough

This PR adds a new Scoop package manifest for easyroam-np, a Windows WiFi utility for German educational institutions. The manifest includes version metadata, architecture-specific download configuration with hash verification, desktop shortcuts, and automated version checking and update templating.

Changes

Scoop Package Manifest for easyroam-np

Layer / File(s) Summary
Package Manifest
bucket/easyroam-np.json
New Scoop manifest defining version 1.0.0, description, homepage, license, 64-bit architecture with download URL and SHA256 hash, desktop shortcut configuration, JSON-based version detection endpoint, and autoupdate URL templating for automatic updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A manifest blooms in JSON form,
For WiFi profiles, safe and warm,
With checksums and auto-update cheer,
easyroam's package is finally here! 📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'easyroam: add version 1.4.7' accurately and concisely describes the main change: adding a new package manifest for easyroam version 1.4.7.
Description check ✅ Passed The PR description references closing #581 and includes the required contributor checklist confirming the Contributing Guide was read, meeting the template's main requirements.
Linked Issues check ✅ Passed The PR successfully addresses all coding requirements from issue #581: adding the easyroam package manifest with correct homepage, download URL, version, and metadata as specified in the package request.
Out of Scope Changes check ✅ Passed All changes are in-scope: the PR adds the easyroam-np.json manifest file and performs linting/auto-update fixes directly related to the package addition requested in #581.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tie-ling

tie-ling commented May 6, 2026

Copy link
Copy Markdown
Author

/verify

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

easyroam-np

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/easyroam-np.json (1)

5-5: 💤 Low value

Consider linking the license URL instead of the bare "Proprietary" string

The license field accepts a string or hash of the software license. For well-known licenses, the SPDX identifier should be used; for other licenses, the URL of the license should be used if available. If easyroam publishes terms of use or an EULA at a public URL (e.g., on their website), prefer that URL over the generic "Proprietary" string.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/easyroam-np.json` at line 5, Replace the bare "Proprietary" value in
the JSON `license` field with a proper identifier or a URL: if the project uses
a well-known SPDX license, use its SPDX identifier string (e.g., "MIT") for the
`license` key, otherwise replace the value with the public URL to easyroam's
terms/EULA (e.g., "https://easyroam.example.com/eula") so the `license` field
contains either a standard SPDX id or a link to the license document instead of
the generic "Proprietary".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/easyroam-np.json`:
- Around line 8-10: The package URL currently uses a "#/dl.7z" suffix which
causes Scoop to treat the MSIX as an archive; remove that suffix from the "url"
value and update the manifest to install the MSIX via proper registration: add a
nonportable "installer" entry that calls Add-AppxPackage to register the .msix
(and an "uninstaller" entry using Remove-AppxPackage to unregister), and update
the "autoupdate" logic to produce the URL without the "#/dl.7z" suffix; ensure
the new installer/uninstaller reference the same filename produced by the "url"
and that the MSIX is actually registered rather than just extracted.

---

Nitpick comments:
In `@bucket/easyroam-np.json`:
- Line 5: Replace the bare "Proprietary" value in the JSON `license` field with
a proper identifier or a URL: if the project uses a well-known SPDX license, use
its SPDX identifier string (e.g., "MIT") for the `license` key, otherwise
replace the value with the public URL to easyroam's terms/EULA (e.g.,
"https://easyroam.example.com/eula") so the `license` field contains either a
standard SPDX id or a link to the license document instead of the generic
"Proprietary".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c8138d17-1786-487c-b753-576fa99d3a1e

📥 Commits

Reviewing files that changed from the base of the PR and between 2221efa and 3f9f18e.

📒 Files selected for processing (1)
  • bucket/easyroam-np.json

Comment thread bucket/easyroam-np.json
@tie-ling

tie-ling commented May 6, 2026

Copy link
Copy Markdown
Author

/verify

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

easyroam-np

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request] easyroam.de

1 participant