easyroam: add version 1.4.7#582
Conversation
Closes ScoopInstaller#581 Signed-off-by: Yan Cao <git@apvc.uk>
WalkthroughThis PR adds a new Scoop package manifest for easyroam-np, a Windows WiFi utility for German educational institutions. The manifest includes version metadata, architecture-specific download configuration with hash verification, desktop shortcuts, and automated version checking and update templating. ChangesScoop Package Manifest for easyroam-np
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with easyroam-np
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/easyroam-np.json (1)
5-5: 💤 Low valueConsider linking the license URL instead of the bare
"Proprietary"stringThe
licensefield accepts a string or hash of the software license. For well-known licenses, the SPDX identifier should be used; for other licenses, the URL of the license should be used if available. If easyroam publishes terms of use or an EULA at a public URL (e.g., on their website), prefer that URL over the generic"Proprietary"string.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/easyroam-np.json` at line 5, Replace the bare "Proprietary" value in the JSON `license` field with a proper identifier or a URL: if the project uses a well-known SPDX license, use its SPDX identifier string (e.g., "MIT") for the `license` key, otherwise replace the value with the public URL to easyroam's terms/EULA (e.g., "https://easyroam.example.com/eula") so the `license` field contains either a standard SPDX id or a link to the license document instead of the generic "Proprietary".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/easyroam-np.json`:
- Around line 8-10: The package URL currently uses a "#/dl.7z" suffix which
causes Scoop to treat the MSIX as an archive; remove that suffix from the "url"
value and update the manifest to install the MSIX via proper registration: add a
nonportable "installer" entry that calls Add-AppxPackage to register the .msix
(and an "uninstaller" entry using Remove-AppxPackage to unregister), and update
the "autoupdate" logic to produce the URL without the "#/dl.7z" suffix; ensure
the new installer/uninstaller reference the same filename produced by the "url"
and that the MSIX is actually registered rather than just extracted.
---
Nitpick comments:
In `@bucket/easyroam-np.json`:
- Line 5: Replace the bare "Proprietary" value in the JSON `license` field with
a proper identifier or a URL: if the project uses a well-known SPDX license, use
its SPDX identifier string (e.g., "MIT") for the `license` key, otherwise
replace the value with the public URL to easyroam's terms/EULA (e.g.,
"https://easyroam.example.com/eula") so the `license` field contains either a
standard SPDX id or a link to the license document instead of the generic
"Proprietary".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c8138d17-1786-487c-b753-576fa99d3a1e
📒 Files selected for processing (1)
bucket/easyroam-np.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. easyroam-np
|
Closes #581
Closes #XXXX
Relates to #XXXX
Summary by CodeRabbit