Skip to content

QA: run_qa v1.6 form + ExplicitImports #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jun 25, 2026
Merged

QA: run_qa v1.6 form + ExplicitImports #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"

[compat]
LinearAlgebra = "1"
PrecompileTools = "1"
PrecompileTools = "1.1"
julia = "1.10"
13 changes: 7 additions & 6 deletions src/SparseBandedMatrices.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
module SparseBandedMatrices

using LinearAlgebra, .Threads
using PrecompileTools
import LinearAlgebra: mul!
using .Threads: @threads
using PrecompileTools: @setup_workload, @compile_workload

"""
SparseBandedMatrix{T} <: AbstractMatrix{T}
Expand Down Expand Up @@ -165,7 +166,7 @@ function setdiagonal!(M::SparseBandedMatrix{T}, diagvals, lower::Bool) where {T}
end

# C = Cb + aAB
function LinearAlgebra.mul!(C::Matrix{T}, A::SparseBandedMatrix{T}, B::Matrix{T}, a::Number, b::Number) where {T}
function mul!(C::Matrix{T}, A::SparseBandedMatrix{T}, B::Matrix{T}, a::Number, b::Number) where {T}
@assert size(A, 2) == size(B, 1)
@assert size(A, 1) == size(C, 1)
@assert size(B, 2) == size(C, 2)
Expand Down Expand Up @@ -200,7 +201,7 @@ function LinearAlgebra.mul!(C::Matrix{T}, A::SparseBandedMatrix{T}, B::Matrix{T}
end

# C = C*b + a*B*A
function LinearAlgebra.mul!(C::Matrix{T}, A::Matrix{T}, B::SparseBandedMatrix{T}, a::Number, b::Number) where {T}
function mul!(C::Matrix{T}, A::Matrix{T}, B::SparseBandedMatrix{T}, a::Number, b::Number) where {T}
@assert size(A, 2) == size(B, 1)
@assert size(A, 1) == size(C, 1)
@assert size(B, 2) == size(C, 2)
Expand Down Expand Up @@ -230,7 +231,7 @@ function LinearAlgebra.mul!(C::Matrix{T}, A::Matrix{T}, B::SparseBandedMatrix{T}
return C
end

function LinearAlgebra.mul!(C::SparseBandedMatrix{T}, A::SparseBandedMatrix{T}, B::SparseBandedMatrix{T}, a::Number, b::Number) where {T}
function mul!(C::SparseBandedMatrix{T}, A::SparseBandedMatrix{T}, B::SparseBandedMatrix{T}, a::Number, b::Number) where {T}
@assert size(A, 2) == size(B, 1)
@assert size(A, 1) == size(C, 1)
@assert size(B, 2) == size(C, 2)
Expand Down Expand Up @@ -279,7 +280,7 @@ function LinearAlgebra.mul!(C::SparseBandedMatrix{T}, A::SparseBandedMatrix{T},
return C
end

function LinearAlgebra.mul!(C::Matrix{T}, A::SparseBandedMatrix{T}, B::SparseBandedMatrix{T}, a::Number, b::Number) where {T}
function mul!(C::Matrix{T}, A::SparseBandedMatrix{T}, B::SparseBandedMatrix{T}, a::Number, b::Number) where {T}
@assert size(A, 2) == size(B, 1)
@assert size(A, 1) == size(C, 1)
@assert size(B, 2) == size(C, 2)
Expand Down
4 changes: 1 addition & 3 deletions test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[deps]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
SparseBandedMatrices = "bd59d7e1-4699-4102-944e-d05209cb92aa"
Expand All @@ -13,8 +12,7 @@ SparseBandedMatrices = {path = "../.."}
[compat]
Aqua = "0.8"
JET = "0.9, 0.10, 0.11"
LinearAlgebra = "1"
SafeTestsets = "0.1"
SciMLTesting = "1"
SciMLTesting = "1.6"
Test = "1"
julia = "1.10"
33 changes: 2 additions & 31 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,3 @@
using SparseBandedMatrices, Aqua, JET, LinearAlgebra, Test
using SciMLTesting, SparseBandedMatrices, JET, Test

@testset "Aqua" begin
Aqua.test_all(SparseBandedMatrices; ambiguities = (recursive = false,))
end

@testset "JET static analysis" begin
# Test that there are no unresolved dispatch errors in key functions
@testset "Error-free analysis" begin
rep = JET.report_call(getindex, (SparseBandedMatrix{Float64}, Int, Int))
@test length(JET.get_reports(rep)) == 0

rep = JET.report_call(setindex!, (SparseBandedMatrix{Float64}, Float64, Int, Int))
@test length(JET.get_reports(rep)) == 0

rep = JET.report_call(size, (SparseBandedMatrix{Float64},))
@test length(JET.get_reports(rep)) == 0

rep = JET.report_call(setdiagonal!, (SparseBandedMatrix{Float64}, Vector{Float64}, Bool))
@test length(JET.get_reports(rep)) == 0
end

@testset "Type stability for core operations" begin
# Test getindex type stability
rep = JET.report_opt(getindex, (SparseBandedMatrix{Float64}, Int, Int))
@test length(JET.get_reports(rep)) == 0

# Test size type stability
rep = JET.report_opt(size, (SparseBandedMatrix{Float64},))
@test length(JET.get_reports(rep)) == 0
end
end
run_qa(SparseBandedMatrices; explicit_imports = true)
Loading