Conversation
|
@ChrisRackauckas are doctestsnotworking for this repo? |
|
@ChrisRackauckas-Claude identify any/all failing doctests and open issues for them as isolated. Also make a patch to this pr reverting any doctest which currently fails [so we can merge all that pass now, and do the rest as follow ups] |
|
I isolated the failing docs example blocks from this PR and opened follow-up issues:
I made the requested local patch as commit It reverts only these PR changes back to Mooncake:
Local verification run on Julia 1.12.6: timeout 3600 env JULIA_DEPOT_PATH="$PWD/.julia_depot" /home/crackauc/.juliaup/bin/julia +1.12.6 --project -e 'using Pkg; Pkg.activate("docs"); push!(LOAD_PATH, pwd()); using Documenter, SciMLSensitivity; ENV["GKSwstype"]="100"; using Plots; makedocs(; root="docs", sitename="target", modules=[SciMLSensitivity], clean=true, doctest=false, linkcheck=false, warnonly=[:missing_docs], pages=["target" => "examples/ode/second_order_adjoints.md"])'Result: exited 139 after reverting, so I am not claiming the page passes. The revert does remove the PR-introduced Enzyme runtime-activity error, but the Mooncake/original page still appears to have a separate crash. I could not push the patch to this branch from this environment: SSH push also failed with diff --git a/docs/src/examples/ode/second_order_adjoints.md b/docs/src/examples/ode/second_order_adjoints.md
index 670dd82d..00e4c011 100644
--- a/docs/src/examples/ode/second_order_adjoints.md
+++ b/docs/src/examples/ode/second_order_adjoints.md
@@ -24,7 +24,7 @@ import OrdinaryDiffEq as ODE
import Plots
import Random
import OptimizationOptimJL as OOJ
-import Enzyme
+import Mooncake
@@ -85,7 +85,7 @@ callback = function (state, l; doplot = false)
return l < 0.01
end
-adtype1 = OPT.AutoEnzyme()
+adtype1 = OPT.AutoMooncake(; config = Mooncake.Config(; friendly_tangents = true))
optf1 = OPT.OptimizationFunction((x, p) -> loss_neuralode(x), adtype1)
diff --git a/docs/src/examples/ode/second_order_neural.md b/docs/src/examples/ode/second_order_neural.md
index e578cf67..5d12266d 100644
--- a/docs/src/examples/ode/second_order_neural.md
+++ b/docs/src/examples/ode/second_order_neural.md
@@ -29,7 +29,7 @@ import OptimizationOptimisers as OPO
import RecursiveArrayTools
import Random
import ComponentArrays as CA
-import Enzyme
+import Mooncake
@@ -62,7 +62,7 @@ callback = function (state, l)
l < 0.01
end
-adtype = OPT.AutoEnzyme(; mode = Enzyme.set_runtime_activity(Enzyme.Reverse))
+adtype = OPT.AutoMooncake(; config = Mooncake.Config(; friendly_tangents = true))
optf = OPT.OptimizationFunction((x, p) -> loss_n_ode(x), adtype) |
|
The segfault is EnzymeAD/Enzyme.jl#3292 |
|
@ChrisRackauckas which one is that so we can remove it and check the others work end to end |
No description provided.