Skip to content

Add ADTypes to ComplicatedPDE Project.toml [deps]/[compat]#1590

Closed
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:fix/complicatedpde-adtypes-dep
Closed

Add ADTypes to ComplicatedPDE Project.toml [deps]/[compat]#1590
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:fix/complicatedpde-adtypes-dep

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Please ignore until reviewed by @ChrisRackauckas.

Summary

benchmarks/ComplicatedPDE/Filament.jmd does using SciMLLogging, ADTypes (line 21), but ADTypes was only in the Manifest as a transitive dep, not in [deps]. Julia's using only resolves top-level project deps, so the chunk evaluation fails:

ERROR: ArgumentError: Package ADTypes not found in current path.
- Run `import Pkg; Pkg.add("ADTypes")` to install the ADTypes package.
in expression starting at .../benchmarks/ComplicatedPDE/Filament.jmd:6

This was masked in CI because SciMLBenchmarks.weave_file catches per-file ProcessFailedException via @error at src/SciMLBenchmarks.jl:100 and does not re-throw — so benchmark.jl exits 0 and the workflow appears successful even though Filament.jmd failed to weave.

This is a follow-up to #1580 (now merged). The bug is currently live on master.

Changes

benchmarks/ComplicatedPDE/Project.toml:

  • [deps]: add ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b" (UUID matches the existing Manifest entry; ADTypes v1.22.0).
  • [compat]: add ADTypes = "1".

No other .jmd files in ComplicatedPDE reference packages missing from [deps] (scanned Filament.jmd and SpringBlockNonLinearResistance.jmd).

Test plan

  • julia +1.11 --project=benchmarks/ComplicatedPDE -e 'using Pkg; Pkg.instantiate(); using ADTypes; println(pathof(ADTypes))' succeeds locally → ADTypes loaded OK: /home/.../packages/ADTypes/tzjfw/src/ADTypes.jl.
  • CI weaves Filament.jmd without the "Package ADTypes not found" error.

Filament.jmd does `using SciMLLogging, ADTypes` but ADTypes was only
in the Manifest as a transitive dep, so the chunk eval failed with
"Package ADTypes not found in current path". CI marked the job
success only because SciMLBenchmarks.weave_file catches per-file
ProcessFailedException via @error and doesn't re-throw — benchmark.jl
exits 0 even though Filament.jmd actually failed.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #1589 (opened a few minutes earlier with the same one-line Project.toml fix off current master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants