Add ADTypes to ComplicatedPDE Project.toml [deps]/[compat]#1590
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Add ADTypes to ComplicatedPDE Project.toml [deps]/[compat]#1590ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Filament.jmd does `using SciMLLogging, ADTypes` but ADTypes was only in the Manifest as a transitive dep, so the chunk eval failed with "Package ADTypes not found in current path". CI marked the job success only because SciMLBenchmarks.weave_file catches per-file ProcessFailedException via @error and doesn't re-throw — benchmark.jl exits 0 even though Filament.jmd actually failed. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
Closing as duplicate of #1589 (opened a few minutes earlier with the same one-line Project.toml fix off current master). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Summary
benchmarks/ComplicatedPDE/Filament.jmddoesusing SciMLLogging, ADTypes(line 21), butADTypeswas only in the Manifest as a transitive dep, not in[deps]. Julia'susingonly resolves top-level project deps, so the chunk evaluation fails:This was masked in CI because
SciMLBenchmarks.weave_filecatches per-fileProcessFailedExceptionvia@erroratsrc/SciMLBenchmarks.jl:100and does not re-throw — sobenchmark.jlexits 0 and the workflow appears successful even thoughFilament.jmdfailed to weave.This is a follow-up to #1580 (now merged). The bug is currently live on master.
Changes
benchmarks/ComplicatedPDE/Project.toml:[deps]: addADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"(UUID matches the existing Manifest entry; ADTypes v1.22.0).[compat]: addADTypes = "1".No other
.jmdfiles inComplicatedPDEreference packages missing from[deps](scannedFilament.jmdandSpringBlockNonLinearResistance.jmd).Test plan
julia +1.11 --project=benchmarks/ComplicatedPDE -e 'using Pkg; Pkg.instantiate(); using ADTypes; println(pathof(ADTypes))'succeeds locally →ADTypes loaded OK: /home/.../packages/ADTypes/tzjfw/src/ADTypes.jl.Filament.jmdwithout the "Package ADTypes not found" error.