Allow EigenvalueTarget in ExplicitImports QA#1425
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Allow EigenvalueTarget in ExplicitImports QA#1425ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
Scratchpad update: reproduced the QA failure on clean upstream master ( |
Contributor
Author
|
CI update: the GitHub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
SciMLBase.EigenvalueTargetto the existing ExplicitImports unanalyzable allowlist for EnumX-generated modules.ReturnCodeandAlgorithmInterpretation.Local verification
timeout 3600 env GROUP=QA ~/.juliaup/bin/julia +1 --project=. -e 'using Pkg; Pkg.test(; coverage=false)'QA | 15 pass / 15 total;Testing SciMLBase tests passedtimeout 3600 ~/.juliaup/bin/julia +1 -e 'using Runic; exit(Runic.main(["--check", "."]))'git diff --checkBase failure audit
Clean upstream master
c2b0cceef236107656a369c4d5c5aec8f8124d2bfails the same QA command withUnanalyzableModuleExceptionforSciMLBase.EigenvalueTarget.Sidecar audit identified culprit
b892a3809ed8c89cf62215e361ecd11cea4392cc(Add EigenvalueProblem, EigenvalueSolution, and EigenvalueTarget (#1417)), which introducedEigenvalueTargetas anEnumX.@enumxmodule after the EnumX allowlist was added.