Skip to content

Support FunctionProperties 1.1 wrapper predicates#1420

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:compat-functionproperties-1
Jul 8, 2026
Merged

Support FunctionProperties 1.1 wrapper predicates#1420
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:compat-functionproperties-1

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

This PR should be ignored until reviewed by @ChrisRackauckas.

This supports the FunctionProperties 1.1 compat bump from #1418 by extending the SciMLBase weak extension to forward the new public FunctionProperties predicates through AbstractSciMLFunction wrappers.

Changes:

  • allow FunctionProperties = "0.1.7, 1.1"
  • forward FunctionProperties.islinear and FunctionProperties.isautonomous through AbstractSciMLFunction.f
  • extend the FunctionProperties extension tests for wrapper methods and explicit qualified calls where exports overlap

Local verification:

  • timeout 3600 ~/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test(; test_args=["FunctionProperties extension"])'\n - observed FunctionProperties extension | 8 pass\n - observed final Testing SciMLBase tests passed\n- git diff --check\n- timeout 3600 ~/.juliaup/bin/julia +1.10 --startup-file=no -e 'using Pkg; Pkg.activate(; temp=true); Pkg.add("Runic"); using Runic; exit(Runic.main(["--check", "."]))'\n\nNotes:\n- The Pkg.test invocation ran the broader SciMLBase suite despite the test argument; I let it complete and it passed.\n- This is intended as the small compatibility follow-up for build(deps): update FunctionProperties requirement from 0.1.7 to 0.1.7, 1.1 in the all-julia-packages group across 1 directory #1418 rather than modifying the Dependabot branch directly.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review July 8, 2026 07:39
@ChrisRackauckas ChrisRackauckas merged commit 2ae58c8 into SciML:master Jul 8, 2026
33 of 63 checks passed
Comment thread Project.toml
Enzyme = "0.13"
ForwardDiff = "0.10.36, 1"
FunctionProperties = "0.1.7"
FunctionProperties = "0.1.7, 1.1"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compat extension is not correct because islinear was introduce in 1.x in SciML/FunctionProperties.jl#66

The downstream tests involving SciMLSensitivity are broken https://github.com/SciML/SciMLBase.jl/actions/runs/28925741151/job/85813143959#step:11:2154 by this because SciMLSensitivity does not yet allow FunctionProperties v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants