Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)#1416
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)#1416ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Replace the `Mooncake = "0.4, 0.5"` union in the root Project.toml and test/downstream/Project.toml with a single floor at the latest, `Mooncake = "0.5.36"`. This stops the downgrade min-resolution from being able to pin an ancient Mooncake, which was the source of the promotion- caused Downgrade Unsatisfiable wall. Patch-bump the root package version since narrowing a weakdep [compat] floor is a patch-level change. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
Closing. Verified locally (ran the action's own downgrade.jl on the identical commit CI failed on) that raising the Mooncake compat floor does NOT fix the Downgrade lane. The failure is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
Mooncake = "0.4, 0.5"union with a single floor at the latest,Mooncake = "0.5.36", in every Project.toml that declares a Mooncake[compat]entry. Dropping the old0.4, 0.5union stops the downgrade min-resolution from being able to pin an ancient Mooncake — the "limit to latest Mooncake" fix for the promotion-caused DowngradeUnsatisfiablewall.Raised floors
Project.toml(root, weakdep)0.4, 0.50.5.36test/downstream/Project.toml(full dep)0.4, 0.50.5.36Root package version patch-bumped
3.31.0 -> 3.31.1(narrowing a weakdep[compat]floor is a patch-level change; no public-API change).test/downstream/Project.tomlis an unnamed test env, so no version bump there. Only[compat]Mooncake lines were touched — the[deps]/[weakdeps]UUID entries are unchanged.Verification — resolves_at_min = TRUE (observed)
Reproduced the downgrade min-resolution with the actual
julia-actions/julia-downgrade-compatdowngrade.jl(currentmain, incl. #49/#50/#51 merged-test-deps +[sources]handling) on Julia 1.12, cloningResolver.jlexactly as CI does:.(the CI invocation:projects=".",mode=deps) —Successfully resolved minimal versions for .(exit 0). Mooncake is a weakdep here, so it enters the manifest only as aDifferentiationInterfaceextension reference, not a version-pinned dep; the resolve succeeds regardless.test/downstream/Project.toml(Mooncake is a full[deps]) —Successfully resolved minimal versions(exit 0). Mooncake pins to 0.5.36 (was 0.5.25 under the old0.4, 0.5floor — the current registry + merged compat constraints from ModelingToolkit etc. already prevented an ancient 0.4.x even before this change).So on the current tooling the Resolver-capacity
Unsatisfiablewall does not reproduce here; the floor-raise resolves cleanly at minimum versions in both projects and pins Mooncake to the intended 0.5.36 where it is a real dependency.resolves_at_min = true; no dependency on #52 for this repo.Please ignore until reviewed by @ChrisRackauckas.