Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)#626
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)#626ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Raise the Mooncake [compat] floor from "0.5" to "0.5.36" (the latest Mooncake release) in the root Project.toml and test/AD/Project.toml, the two projects that declare a Mooncake compat entry. The old "0.5" floor let the Downgrade min-resolution pin the ancient Mooncake 0.5.0, which drags in stale/incompatible transitive deps. Pinning a single floor at the latest keeps the downgrade lane on a modern Mooncake. Verified on Julia 1.12 with julia-actions/julia-downgrade-compat@v2 (v2.5.2, the version pinned by SciML/.github downgrade.yml@v1): min-resolution of test/AD succeeds and pins Mooncake to exactly 0.5.36 (resolves_at_min = true). The root Core downgrade also resolves (Mooncake stays a weakdep, excluded from deps-mode resolution). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
Closing. Verified locally (ran the action's own downgrade.jl on the identical commit CI failed on) that raising the Mooncake compat floor does NOT fix the Downgrade lane. The failure is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the Mooncake
[compat]floor to the latest Mooncake release (0.5.36) in every Project.toml that declares a Mooncake compat entry, so the Downgrade lane stops pinning an ancient Mooncake.Raised floors
Project.toml(root, weakdep)Mooncake = "0.5"Mooncake = "0.5.36"test/AD/Project.toml(hard dep)Mooncake = "0.5"Mooncake = "0.5.36"Root package version bumped
4.3.2->4.3.3(a[compat]narrowing on a weakdep is a patch-level change).test/AD/Project.tomlis a test env with noversionfield, so nothing to bump there.Why
The old
"0.5"floor let the Downgrade min-resolution pin Mooncake 0.5.0 (verified below), the oldest 0.5.x, which drags in stale/incompatible transitive deps. Pinning a single floor at the latest keeps the downgrade lane on a modern Mooncake.Verification (resolves_at_min)
Ran
julia-actions/julia-downgrade-compat@v2(v2.5.2 — the version pinned bySciML/.githubdowngrade.yml@v1) on Julia 1.12, min mode (--min=@deps):test/AD(Mooncake hard dep): resolves_at_min = true. Resolution succeeds; Mooncake pins to exactly 0.5.36 (ForwardDiff 0.10.38, ReverseDiff 1.15.0, Zygote 0.7.0 all at their floors). With the old"0.5"floor the same resolve pinned Mooncake 0.5.0..Core downgrade: resolves. Indepsmodedowngrade-compat@v2does not promote weakdeps, so Mooncake stays a weakdep and is excluded from the root merged resolution; the root resolves cleanly.No
Unsatisfiableon this repo withdowngrade-compat@v2. The floor-raise is the correct "limit to latest Mooncake" fix, and resolution succeeds at min after the bump.Please ignore until reviewed by @ChrisRackauckas.